mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <chanwoo@kernel.org>
To: Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mfd: max77686: Convert to use maple tree register cache
Date: Tue, 3 Oct 2023 17:25:49 +0900	[thread overview]
Message-ID: <4fe44a5f-9a6f-5259-f14a-d464a7cb8556@kernel.org> (raw)
In-Reply-To: <20231001-mfd-maxim-maple-v1-2-cdfeb48a4d15@kernel.org>

Hi,

On 23. 10. 1. 08:47, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/mfd/max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 91c286c4571c..0118a444a68b 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -108,7 +108,7 @@ static const struct regmap_config max77802_regmap_config = {
>  	.precious_reg = max77802_is_precious_reg,
>  	.volatile_reg = max77802_is_volatile_reg,
>  	.name = "max77802-pmic",
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  };
>  
>  static const struct regmap_irq max77686_irqs[] = {
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi


  parent reply	other threads:[~2023-10-03  8:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 23:47 [PATCH 0/3] mfd: maxim: Convert to use maple tree cache Mark Brown
2023-09-30 23:47 ` [PATCH 1/3] mfd: max77620: Convert to use maple tree register cache Mark Brown
2023-09-30 23:47 ` [PATCH 2/3] mfd: max77686: " Mark Brown
2023-10-03  6:29   ` Krzysztof Kozlowski
2023-10-03  8:25   ` Chanwoo Choi [this message]
2023-09-30 23:47 ` [PATCH 3/3] mfd: max8907: " Mark Brown
2023-10-03  6:29   ` Krzysztof Kozlowski
2023-10-05 14:38 ` [PATCH 0/3] mfd: maxim: Convert to use maple tree cache Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fe44a5f-9a6f-5259-f14a-d464a7cb8556@kernel.org \
    --to=chanwoo@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®