From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6703EFD2D for ; Tue, 30 Jun 2026 10:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814573; cv=none; b=fE+YrDjTNGfP2BLI1HqipNQjJPO+bV6IRZLLcPBSGIl4OJLb9t/fwExQ416TC6djGdfy8WYCMEEy8xR1gNjEtvcw07wC/kC4H/Vtvc56CcPEwZB5gWHUsI3cOsDHdDDXKUdpkIS3KDrPTJd9FkhEyotAEYWRPKrcXGj1qrGWozo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814573; c=relaxed/simple; bh=lRKXJKZrP495IiUZDHG4weeCWTHu4o8bUjJfmGNlq8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ToAe7Ay7HdiR7/g6uBvkgUE8YOcVqnV/othcBnzyEWSZtn8m5vYMUGa/NM4B4YGl2GJty2DYqo9JoTWE+OIZ/Y+2gBKZIPiJHCiuV5xFC2JIaTGWDesbAXkd1fwoNvWysbdvT0pi4PIbQuf0hTN9TUABKQdPO+gJZgJtUtx2ekI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CImSIX+l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Rxegup9T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CImSIX+l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Rxegup9T" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9mwm51542224 for ; Tue, 30 Jun 2026 10:16:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P7blyNdpZKWQkeLr0/kR8NAwTa+IR77dLcCC5jAo5Pc=; b=CImSIX+lnYq6QRGC gfkBDthWL1CvqXsbiRVsRpxi3pFdzMuBGz85OsV++lx0BqyyGS9RQbt0WKHpB7MG vY2oWnceAoDcB6q7audWseEFs0NHaOpS4Qmk0q2mS5kGIIEKRc+PivXDv3HykPeR bjnH6Xl43aWpdZVOLUxueVOlQQFU5Ut7AcRZDwovSkzWpAEKsdKCjW6z/qmYSm0Z B0oLZMv5T1xjSHHaejA9tMj2wnWLomphV90mWkk6AzZaqVU86D/TgMU3ydl444xZ ICrq0AArOqkWtFn6ELk59EpGLc/89XpHh94Qw3kpEU6MVQ8aaazVCZ1Glli1DJ4Z wyI08g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f44v4hut1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 10:16:09 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bea07880dso7774601cf.0 for ; Tue, 30 Jun 2026 03:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782814568; x=1783419368; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=P7blyNdpZKWQkeLr0/kR8NAwTa+IR77dLcCC5jAo5Pc=; b=Rxegup9TuMBqrFwoI2Rubqz1X01lq7BdUGi0JcDKbywzUy1GWll1EThTy4E+nWzLmT jOZYZsZZ1/MbFDKOukp+lbbZHmJjKh5S1IJFjcxYX+JPTocShpDuG8ofCsdscP8tW4mD lOuEFgaRraR/isBgByXG+SZZRuEl36qyLPBbf7wqItBQYT7sgwYTdml7O2Ph0cax8KcW H5uZ39xtRuZtpPp75vi0zYlTkLhZCJL6tVL4VeDfG/bBH5rOQKAZZyaSvuORld2L7swv yCnHX07T5U4skvdRECC/eT0cM9YMYz3SPc+6PIxwADOa54IyTUUcIRkT3sALpnN84vCr GQ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782814568; x=1783419368; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P7blyNdpZKWQkeLr0/kR8NAwTa+IR77dLcCC5jAo5Pc=; b=HRVAEYqqSRXra7XJJh8YMlpU5WxrJcJ2gC6qwu9OFiSiZ9c7ZnyhIeLXLuAZ/3x5AS FVvapzC+w6KKpA/J5AskuPaa/WcW6MBe3+fseADg5Q7BJzXY6HN0JNPkchUtiaRrtyxZ NFIYePedjc+q8IeytSJ7BZ+1TkxLl9I2oYqilYLNRqq1N7c5MG1uwDSWIDg7QmTLoN1x QMkBu+RCc6hbCA64mvyYVGOjoTuuTg8ZduYkTYdIgVxkRJfvQ5xeWv1xhmVrW5RC0EGQ Td397/ffHpeN8EErcGmOct0KxePvXw4TxctQ8oh23F1M+aoZj671OIbPaSPP8zhU9sB8 VFXg== X-Forwarded-Encrypted: i=1; AFNElJ8mYW5UO1GKjRA1upO4RQkbLER21dmDg3wi6xDAF8vbWzZwPkmbz4f2UTLHWFDjlZFoX6zQCxPrdDfRYqc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp3H9jDkA1TxTuQqgBkjphA7sPDOfcK0S6wzhUkjPUx9/i5JNZ xdMWKoa/Zo1FYv8mkr65+cRDyZm9V4/CUWFzr2+vPWUF4E67qVpUxLht8lUVEWmtdPUJqertgZm Qg7nSF8nzoZ4BmrAbmalHgJS2fUI2htzHCn837kVJtHiEcg9clCUR6Q4YCJSg7mKtncg= X-Gm-Gg: AfdE7cn8fkJRarS0xpJ3yzl+iMhx2HXn3cTzeF3nETPp/sMO/jQhBHMdmD0kB5dOznp OR2qAw9/ofJBvh+TER0FH3rQMyK7UlCYP02JyDu/NyL0JPjUxhdE71cUMH/puVKQ90wKaNdG1Wv EPifajmUTsq5EEPbzvN0LfqnixKRl4BgZhpthAIo0fqNUvU4spJwoQTAhYwfJZziRsrX96a5TA3 0cFXILu8E1SnKbly1Js/GgOFLWyF6zLBbqst64/Df2EELlqFq0bL+MJysoZGqb1L+b2cKXEgJ7b 7iOKMh6SSOQdid/L36GE5LOIYrJ842n5OpwinpcYNV2vEjLpDrAuWAb1m9Of9YgQxPN/nEwsV3X tlwGj5H9gKrzq1gOH3cITjO7EgQe9VrvRCdM= X-Received: by 2002:a05:622a:1ba3:b0:51a:88bd:95a0 with SMTP id d75a77b69052e-51c10731d27mr24969691cf.1.1782814568015; Tue, 30 Jun 2026 03:16:08 -0700 (PDT) X-Received: by 2002:a05:622a:1ba3:b0:51a:88bd:95a0 with SMTP id d75a77b69052e-51c10731d27mr24969481cf.1.1782814567520; Tue, 30 Jun 2026 03:16:07 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f0cb41sm98630466b.38.2026.06.30.03.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 03:16:06 -0700 (PDT) Message-ID: <4fe8d4d7-1aa7-4c18-95a5-f0a9d91e820a@oss.qualcomm.com> Date: Tue, 30 Jun 2026 12:16:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/12] clk: qcom: gcc-mdm9607: Fix BIMC PLL definition To: Stephan Gerhold Cc: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-4-5e9717faf842@linaro.org> <022fb465-df10-4d95-a05c-1ff8e59558c1@oss.qualcomm.com> <1b30fd97-b298-435d-83a4-944e536bc8d4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: vd6FIvyjGL7Md-EmpIHVa23egf2gX4ro X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA5MiBTYWx0ZWRfXzLC71qMusZgO x1eFkBVwX4A96diftWSwcz+y13IM1iW8IQf7XCAuLhd/I9F+9WCiMSalAro4Lnb48ZK3s6+3vGf 9HPDXBtiHLNEiMqOEVQg3aWatdW7ouo= X-Authority-Analysis: v=2.4 cv=JI0LdcKb c=1 sm=1 tr=0 ts=6a439769 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=n_5_cvKnsOMzfkmOiNQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: vd6FIvyjGL7Md-EmpIHVa23egf2gX4ro X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA5MiBTYWx0ZWRfX8/CUcDLzzBlK qnqWqgs0ZmIrorjhzcsVKJStWWHy0uM5U/1PMdmA+JIGy5t5MSlYvkyvY3cCBF31P12xBAVU/+S /Bs82myooTJg+f6V3Cl2wpkq0avO7HliKX+qwrlJBSk97xo5t8sgIH9PzCbzg3slbGGrYqrK6KL WTsAF9n+upUKPbVcg3bwcNPADcF8hb0OsI9ftJaiMh5E4elyQY4MjNgyej425Yd4mrAJiG5JUdS BA1zKV6xEcEePWDYJPDETl7EKjtj4ybtU3jl//o3QHfdPOTLRwUMZ6Dx8XFb73M6d9n78lhHU/5 b3bExFDJ/9XNE/KGHDuKrxkQ8/kKhtTe8bYA6UPs0w2ENKgb6vZt1WShxo8e4cJUzZyzcI5nWfu t3M6tTzCYiAUuj8UeI4EWTAyz+yaiK+czplSa0eU5Q2j15neIiEzq4AyLC0U0yDUp6NV4pSPZ7Z rIkAjoBzY8OY7z83Wpg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300092 On 6/29/26 5:49 PM, Stephan Gerhold wrote: > On Tue, Jun 16, 2026 at 12:52:48PM +0200, Konrad Dybcio wrote: >> On 6/10/26 7:58 PM, Stephan Gerhold wrote: >>> On Wed, Jun 10, 2026 at 10:43:12PM +0530, Taniya Das wrote: >>>> On 6/9/2026 7:44 PM, Stephan Gerhold wrote: >>>>> The gcc-mdm9607 driver was originally based on gcc-msm8916, but a closer >>>>> match nowadays is gcc-msm8909. Looking at the differences between >>>>> gcc-mdm9607 and gcc-msm8909, there is quite some confusion around the >>>>> definitions for the BIMC PLL. >>>>> >>>>> It turns out the BIMC PLL on MDM9607 is actually an Alpha PLL just like on >>>>> MSM8909. We can vote for it using BIT(2), which explains why BIT(3) was >>>>> used for GPLL2. >>>> >>>> BIMC PLL is never controlled from High Level OS (APSS). These are >>>> controlled by other subsystems and voting should be via the ICC for BW >>>> requirements. >>>> >>> >>> The driver doesn't really control the BIMC PLL here, the PLL is defined >>> with fixed/shared/read-only ops so it mostly just exists to model the >>> clock tree properly and have the clock rate readable for the PLL itself >>> and any downstream consumers. >>> >>> There are multiple drivers that do it like this (e.g. gcc-msm8916, >>> gcc-msm8939), is there a reason why we should drop this? >> >> My fear is that the kernel may have stale data at any point.. perhaps >> unless we set CLK_GET_RATE_NOCACHE? >> > > Looking into it a bit more, it looks like this "read-only" feature with > firmware managing the clocks is unfortunately a lost cause... > > CLK_GET_RATE_NOCACHE does help for the clock *rate*, but the clock > *parent* is still cached in the clock framework (and only read once when > registering the clock). So if you have clocks switching e.g. between the > BIMC PLL and XO or a GPLL you won't ever see this properly in debugfs. > > In addition, when enabling a child clock branch we make a vote for the > registration time parent (e.g. the BIMC PLL). But if the parent changes > later our vote is never updated and will keep clocks alive even if the > firmware already dropped its votes ... :/ > > I will drop the BIMC PLL and other firmware-managed clocks in v2 like > you suggested. It doesn't seem worth the hassle, and that's what all > newer SoCs do as well. sgtm Konrad