From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D213845B0 for ; Tue, 3 Mar 2026 22:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772578425; cv=none; b=h/cufI9qfasTV1JOdWwq+mhazVg/w03YXfcAfQQ3s0gztg5ZZ/RLOlPtKEMoOxHG4Md66OLBKAfYgAn1IIj95FSvle7UQNZtd1Qpnx8NSs8DCOwjj/F6GqXbfXuWDTyGwYUVvBN5FKS2p3OypQ5Ww2Q43H1ddRLXkSptHQ2ARXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772578425; c=relaxed/simple; bh=jLuXQS5uqPs5ikIuKXGCNbVWA/IDbgIXTJL0nPYHNNY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MbduCEFLmjfeNkYZwjUtnR595eEjo0oatkRrh3HeLeDjhtYe5rSzwCRhat5jK7gP0TTtT/0hSZU2QPmncJBXPyC4ZlUftT4XzzUFtWyOMrQ9B4lvY88LYEKGyVYbcxLLyGPgu+Dr2MkfHrI1wXTHyW7924QlAI94Xd73pBMW05g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u5U4EcsH; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u5U4EcsH" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439b9b190easo1680675f8f.2 for ; Tue, 03 Mar 2026 14:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772578422; x=1773183222; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YS4rmu/Plq/GT8U8U/B/TnIeQy/JnY6psImqbAy1u5E=; b=u5U4EcsHE16Zna6ek1DZ2UZPoG8wkYa4KoK32TRJjGyIobpWvKL6ENvB0wQINrav7A bKsaK8W6pcU+hpd5DYgcknTTv2/av7UC8PeSGp435tWGP4KV0m6HWdGqN7djvzvkqwBj 4SViMdsNd1yLIdjV/Is4BSFbcdZ/WBuBIUky4JkmvTjnv1YuTaJ5kNNWYAQ0uSZ0n0sJ v+mVJ1FrSm7F0ytyFp1qWSunSfxVJQvwGEQyXBORKs5O29l8tCzt+k8TGgBHcxdtTe84 HWnT6q01JQyIXypUSNkS6OmxGTvRXwBdUNRCIFICYnOakK9o5FibaJEJq1G7nBaBT33N d2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772578422; x=1773183222; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YS4rmu/Plq/GT8U8U/B/TnIeQy/JnY6psImqbAy1u5E=; b=BbsWrt3Guav94h/eNpj9tpQqde/Qy/ym9PBYbxwuFVS2Iift34UO4UCztwqmI/buMw 3+RMfUgTw3+u1Sjy8Fifmu8Hnn4x+7O+kfRrf04tQNnO2MS8Udj5lKbpMTIBbKzpeWEF 6jfbBHJbZUkfFx9x65rBX5hj7ASClXSID2n03nm4sLaVLGy8X3n32aOI1C9uYYVdz+RG SIWeHo0w5aEdzN0DpfUZRml7Dz/mNFORHTAPwc973U8U5Ev24H7kNCe4jqbXJHw2XmzO GlK11R3jkCt/K0LU98dNYir5wB+W2qyNmiu7Z9x6p3D23FG4W3R7tZXGoRxxa4FAbWGV embg== X-Forwarded-Encrypted: i=1; AJvYcCVxDioN/tiCUI9djYh86OV9a9AdSO7ZH1PuOSBH2EVyfRNaZApYaEH3vOtiE9l3Aw8ZK6T935gv7HZbrl8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn/xyueNsSjF+R7SIQU8z/GvdOAuf1dQ2dGMkcWZxb4vGMuIEy Kb2yv6QEj1eHH+DT/l0p4TlmBo6mKLZQa2FtJ3MTxR0RnKGFbhapKQtEH0CJwknS7y0= X-Gm-Gg: ATEYQzz3fyx6+DcQvlzuF4DwQWroUQh3YS3iQx51yCnGu4aLWn/kvHGCMm+1q+w+9FQ h9oo+J/YWjzJsgQNcKL9C/2a/lKyxlYeIuKl1qTt79dYcldLTr/xSpnbKEHGFRHaG4Vgj6fv0C4 e/mjnWGNr4vFvOJQPfmYRfaP3uhJErlhSsGDq0wj8Hv4leGm0lpZfUOSfJkCruGnc6g+rQ+DEOK oxosj1RkdobR6oMZMSCXi8qkKjmqOvkhkTuR0sMvrY8BWEV1ewK4Oc4xCPHYxM5XRN5QJCWneyV uId7V9GKIFtu9IHzzMF3e6KSjUfjhC/ql1Ayp4tlamQ17BJr+RPLBVGVvAczITFlYhIDl11+gjM 1N6p9w7o8M3TRiYKj4yJgKEm1s3OfKu5GYWhSXZ3fxUUCiEtS0z5kEAmQUfDWwjYKkgB77uAWNj RRRidBtFjc/Kp5jorbgnT3tQ7jeRx/3tHyHwGUEkuXN7Fr58nRnMvG6etjqPih9mg+KDbCHrlsM FM= X-Received: by 2002:a05:6000:2207:b0:439:bc2b:cb50 with SMTP id ffacd0b85a97d-439c7f64eadmr257072f8f.4.1772578422246; Tue, 03 Mar 2026 14:53:42 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b503425asm20135391f8f.25.2026.03.03.14.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 14:53:40 -0800 (PST) Message-ID: <4fea7117-ebd3-4279-9973-3ac4f2a78835@linaro.org> Date: Tue, 3 Mar 2026 22:53:38 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Vijay Kumar Tumati , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260226-x1e-csi2-phy-v3-0-11e608759410@linaro.org> <20260226-x1e-csi2-phy-v3-1-11e608759410@linaro.org> <4pFL6wOeTKUt-Zq4YbjqJdacMgUIPSYJD-4-5DcIMEZ1sM7JsNFYcSv1bd7ZRVOklTsmkEfxM2b6tTflmiECNQ==@protonmail.internalid> <03b44922-72d5-465b-96e1-97a19655e97d@kernel.org> <4440a3a8-7281-4bea-bb84-7a9d19ef7ce9@oss.qualcomm.com> <2a1155bd-7dc5-4ed8-b1eb-ddfa483c75ca@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <2a1155bd-7dc5-4ed8-b1eb-ddfa483c75ca@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/03/2026 18:58, Vijay Kumar Tumati wrote: >>> - TITAN_TOP_GDSC >>> - MXC >>> - MMCX >>> - MXA - first time I've heard of this rail, from memory I don't remember >>>          having seen this in ipcat when I could do so. >> MCX and MMCX are comminly required power domains across the PHYs but a >> subset of PHYs have the dependency on MXA. > Actually, it's a bit more complicated on this target as > cam_cc_cphy_rx_clk_src also depends on MXA, which means all the CBCs > connected this RCG do as well. Right but that's something to model in the clock-controller then not the PHY. i.e. if a clock depends on MXA then the clock controller should represent that dependency - not the PHY that depends on the clock. camcc on hamoa looks like this camcc: clock-controller@ade0000 { compatible = "qcom,x1e80100-camcc"; reg = <0 0x0ade0000 0 0x20000>; clocks = <&gcc GCC_CAMERA_AHB_CLK>, <&bi_tcxo_div2>, <&bi_tcxo_ao_div2>, <&sleep_clk>; power-domains = <&rpmhpd RPMHPD_MXC>, <&rpmhpd RPMHPD_MMCX>; required-opps = <&rpmhpd_opp_low_svs>, <&rpmhpd_opp_low_svs>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>; }; So... we may need to add MXA here, probably do based on what you've said but I believe TITAN_TOP_GDSC is the only power-domain we need to list for the PHYs themselves, as what you've described above is a clock power dependency which we basically already capture in the clock controller - absent the MXA - which is apparently always on... Sidenote, is MXA required for videocc too ? videocc: clock-controller@aaf0000 { compatible = "qcom,x1e80100-videocc"; reg = <0 0x0aaf0000 0 0x10000>; clocks = <&bi_tcxo_div2>, <&gcc GCC_VIDEO_AHB_CLK>; power-domains = <&rpmhpd RPMHPD_MMCX>, <&rpmhpd RPMHPD_MXC>; required-opps = <&rpmhpd_opp_low_svs>, <&rpmhpd_opp_low_svs>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>; }; --- bod