From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Rob Herring <robh@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
kvmarm@lists.linux.dev, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 12/14] arm64/sysreg: Convert TRBMAR_EL1 register to automatic generation
Date: Tue, 13 Jun 2023 09:31:13 +0530 [thread overview]
Message-ID: <4fec9cf7-b4b6-c5c1-7db5-493240c54ef1@arm.com> (raw)
In-Reply-To: <8a352dec-9655-4e7c-ba35-1c48e154bc71@sirena.org.uk>
On 6/2/23 17:35, Mark Brown wrote:
> On Fri, Jun 02, 2023 at 11:55:50AM +0530, Anshuman Khandual wrote:
>
>> +Sysreg TRBMAR_EL1 3 0 9 11 4
>> +Res0 63:12
>> +Field 11:10 PAS
>> +Field 9:8 SH
>> +Field 7:0 Attr
>> +EndSysreg
>
> PAS and SH look like they should be enums, Attr is a bit more complex so
> Field is probably a good fit there. Adding the enum information could
> be done incrementally though so:
Will fold the following changes in this patch.
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2246,8 +2246,17 @@ EndSysreg
Sysreg TRBMAR_EL1 3 0 9 11 4
Res0 63:12
-Field 11:10 PAS
-Field 9:8 SH
+Enum 11:10 PAS
+ 0b00 SECURE
+ 0b01 NON_SECURE
+ 0b10 ROOT
+ 0b11 REALM
+EndEnum
+Enum 9:8 SH
+ 0b00 NON_SHAREABLE
+ 0b10 OUTER_SHAREABLE
+ 0b11 INNER_SHAREABLE
+EndEnum
Field 7:0 Attr
EndSysreg
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
next prev parent reply other threads:[~2023-06-13 4:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 6:25 [PATCH V2 00/14] arm64/sysreg: Convert TRBE registers " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 01/14] arm64/sysreg: Rename TRBLIMITR_EL1 fields per auto-gen tools format Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 02/14] arm64/sysreg: Rename TRBPTR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 03/14] arm64/sysreg: Rename TRBBASER_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 04/14] arm64/sysreg: Rename TRBSR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 05/14] arm64/sysreg: Rename TRBMAR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 06/14] arm64/sysreg: Rename TRBTRG_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 07/14] arm64/sysreg: Rename TRBIDR_EL1 " Anshuman Khandual
2023-06-02 6:25 ` [PATCH V2 08/14] arm64/sysreg: Convert TRBLIMITR_EL1 register to automatic generation Anshuman Khandual
2023-06-02 11:57 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 09/14] arm64/sysreg: Convert TRBPTR_EL1 " Anshuman Khandual
2023-06-02 11:58 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 10/14] arm64/sysreg: Convert TRBBASER_EL1 " Anshuman Khandual
2023-06-02 11:59 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 11/14] arm64/sysreg: Convert TRBSR_EL1 " Anshuman Khandual
2023-06-02 12:00 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 12/14] arm64/sysreg: Convert TRBMAR_EL1 " Anshuman Khandual
2023-06-02 12:05 ` Mark Brown
2023-06-13 4:01 ` Anshuman Khandual [this message]
2023-06-13 11:03 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 13/14] arm64/sysreg: Convert TRBTRG_EL1 " Anshuman Khandual
2023-06-02 12:06 ` Mark Brown
2023-06-02 6:25 ` [PATCH V2 14/14] arm64/sysreg: Convert TRBIDR_EL1 " Anshuman Khandual
2023-06-02 12:12 ` Mark Brown
2023-06-13 4:26 ` Anshuman Khandual
2023-06-13 11:02 ` Mark Brown
2023-06-08 17:39 ` [PATCH V2 00/14] arm64/sysreg: Convert TRBE registers " Catalin Marinas
2023-06-13 4:27 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fec9cf7-b4b6-c5c1-7db5-493240c54ef1@arm.com \
--to=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®