mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>,
	tj@kernel.org, linux-kernel@vger.kernel.org,
	zyhtheonly@gmail.com, zyhtheonly@yeah.net
Cc: tiozhang@didiglobal.com
Subject: Re: [PATCH] workqueue: format pr_warn exceeds line length in wq_numa_init
Date: Sun, 18 Jun 2023 07:54:45 -0700	[thread overview]
Message-ID: <4fefbd7697c593b25ecc981668cc7bae1a1212d9.camel@perches.com> (raw)
In-Reply-To: <CAJhGHyDTQFCA1KJGZjnb9yV-es5f_rz2mvoXm-RuiKuW2fXvcQ@mail.gmail.com>

On Sun, 2023-06-18 at 09:19 +0800, Lai Jiangshan wrote:
> On Fri, Jun 16, 2023 at 3:00 PM tiozhang <tiozhang@didiglobal.com> wrote:
> > 
> > Format this long line which would potentially let checkpatch complain
> > "WARNING: line length of 103 exceeds 100 columns".
[]
> This patch hurts the readability actually. A few extra characters exceeding
> is Okay for me.
[]
> > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
[]
> > @@ -5959,7 +5959,8 @@ static void __init wq_numa_init(void)
> > 
> >         for_each_possible_cpu(cpu) {
> >                 if (WARN_ON(cpu_to_node(cpu) == NUMA_NO_NODE)) {
> > -                       pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu);
> > +                       pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n",
> > +                               cpu);

What _might_ work reasonably well is to add

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any include and remove "workqueue: " from
all pr_<foo> uses.


  reply	other threads:[~2023-06-18 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  7:00 tiozhang
2023-06-18  1:19 ` Lai Jiangshan
2023-06-18 14:54   ` Joe Perches [this message]
2023-06-20  9:56     ` 张元瀚 Tio Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fefbd7697c593b25ecc981668cc7bae1a1212d9.camel@perches.com \
    --to=joe@perches.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiozhang@didiglobal.com \
    --cc=tj@kernel.org \
    --cc=zyhtheonly@gmail.com \
    --cc=zyhtheonly@yeah.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®