From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561AbeBGPy0 (ORCPT ); Wed, 7 Feb 2018 10:54:26 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:38394 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754231AbeBGPyZ (ORCPT ); Wed, 7 Feb 2018 10:54:25 -0500 Subject: Re: [PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device To: Rob Herring , Kieran Bingham Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Jean-Michel Hautbois , Mauro Carvalho Chehab , Mark Rutland , Hans Verkuil , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1516625389-6362-1-git-send-email-kieran.bingham@ideasonboard.com> <1516625389-6362-2-git-send-email-kieran.bingham@ideasonboard.com> <20180129200813.ifaz2bkkxshiodga@rob-hp-laptop> From: Kieran Bingham Organization: Ideas on Board Message-ID: <4ff04149-9726-716c-306c-819130897c98@ideasonboard.com> Date: Wed, 7 Feb 2018 15:54:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180129200813.ifaz2bkkxshiodga@rob-hp-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 29/01/18 20:08, Rob Herring wrote: > On Mon, Jan 22, 2018 at 12:49:56PM +0000, Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte maps that can be accessed via the main >> I²C ports. Each map has it own I²C address and acts as a standard slave >> device on the I²C bus. >> >> Allow a device tree node to override the default addresses so that >> address conflicts with other devices on the same bus may be resolved at >> the board description level. >> >> Signed-off-by: Jean-Michel Hautbois >> [Kieran: Re-adapted for mainline] >> Signed-off-by: Kieran Bingham >> --- >> Based upon the original posting : >> https://lkml.org/lkml/2014/10/22/469 >> --- >> .../devicetree/bindings/media/i2c/adv7604.txt | 18 ++++++- > > Reviewed-by: Rob Herring Thank you. > In the future, please split bindings to separate patch. Yes, of course - sorry - I should probably have known better here. I was clearly being lazy as the original patch had bindings in with the driver. Although I don't think I've got an excuse for the second patch in the series :D I've split them out for the v2. -- Kieran >> drivers/media/i2c/adv7604.c | 60 ++++++++++++++-------- >> 2 files changed, 55 insertions(+), 23 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >