From: kajoljain <kjain@linux.ibm.com>
To: Tom Rix <trix@redhat.com>,
maximlevitsky@gmail.com, oakad@yahoo.com, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memstick: mspro_block: remove unneeded semicolon
Date: Mon, 2 Nov 2020 21:36:11 +0530 [thread overview]
Message-ID: <4ff202e1-1171-6ad1-5a5a-f384e987f77b@linux.ibm.com> (raw)
In-Reply-To: <df2f3ead-8bf9-144d-8a8a-9d6356f8b389@redhat.com>
On 11/2/20 7:12 PM, Tom Rix wrote:
>
> On 11/1/20 10:51 PM, kajoljain wrote:
>>
>> On 10/31/20 7:18 PM, trix@redhat.com wrote:
>>> From: Tom Rix <trix@redhat.com>
>>>
>>> A semicolon is not needed after a switch statement.
>> Hi Tom,
>> I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
>> any logical issue do we still need to add fix tag?
>
> My rule of thumb is a fix means the kernel needs to be recompiled.
Yes make sense. Thanks for confirming.
Thanks,
Kajol Jain
>
> This isn't a fix.
>
> Tom
>
>>
>> Thanks,
>> Kajol Jain
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>> drivers/memstick/core/mspro_block.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
>>> index cd6b8d4f2335..afb892e7ffc6 100644
>>> --- a/drivers/memstick/core/mspro_block.c
>>> +++ b/drivers/memstick/core/mspro_block.c
>>> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
>>> return "attr_devinfo";
>>> default:
>>> return NULL;
>>> - };
>>> + }
>>> }
>>>
>>> typedef ssize_t (*sysfs_show_t)(struct device *dev,
>>>
>
next prev parent reply other threads:[~2020-11-02 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 13:48 trix
2020-11-02 6:51 ` kajoljain
2020-11-02 13:42 ` Tom Rix
2020-11-02 16:06 ` kajoljain [this message]
2020-11-05 12:58 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff202e1-1171-6ad1-5a5a-f384e987f77b@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
--cc=trix@redhat.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®