Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

[Suman Anna <s-anna@ti.com>]

On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
> On 07/17/2017 10:28 PM, Suman Anna wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>
>> Add the ti-sci node representing this 66AK2G PMMC module.
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> [s-anna@ti.com: add unit address to DT node]
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index a789f75a1ed5..7f0f4180b373 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -139,5 +139,19 @@
>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>  		};
>> +
>> +		pmmc: pmmc@02921c00 {
>> +			compatible = "ti,k2g-sci";
>> +			/*
>> +			 * In case of rare platforms that does not use k2g as
>> +			 * system master, use /delete-property/
>> +			 */
> 
> This comment seems mis-worded, I believe this was meant to say "for
> platforms that do not use the *PMMC* as the system master".

The comment is for the system-reboot-controller property, and is meant
to say that this property is to be deleted from this node if there is an
external entity on the board other than the K2G SoC that is responsible
for triggering a reboot.

regards
Suman

> 
> Andrew
> 
>> +			ti,system-reboot-controller;
>> +			mbox-names = "rx", "tx";
>> +			mboxes= <&msgmgr 5 2>,
>> +				<&msgmgr 0 0>;
>> +			reg-names = "debug_messages";
>> +			reg = <0x02921c00 0x400>;
>> +		};
>>  	};
>>  };
>>