mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sasaki tatsuya <tatsuya6.sasaki@kioxia.com>
To: Hannes Reinecke <hare@suse.de>, "hch@lst.de" <hch@lst.de>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] nvme: update keep alive interval when kato is modified
Date: Mon, 30 Aug 2021 11:27:53 +0000	[thread overview]
Message-ID: <4ffa643335a9467ba586450f8820c54a@kioxia.com> (raw)
In-Reply-To: <2fc5b98a-b397-3be1-1957-986e8b6aa732@suse.de>

> On 8/25/21 10:53 AM, hch@lst.de wrote:
> > Any reason we can't just call this from nvme_passthru_end instead
> > of inventing a new API?  Right now the nvmet passthrough code never
> > uses the underlying keep alive code, so it doesn't make a difference,
> > but I expect we'll need more handling for passthrough commands like
> > this, and we might also grow more users (e.g. the io_uring based
> > passthrough).
> >
> Yeah, we'll need that anyway if and when hostid becomes settable.

Thanks for your comments. To call nvme_update_keep_alive from
nvme_passthru_end, I think nvme_passthru_end needs an argument of
a pointer to nvme_command. I will try to call it from nvme_passthru_end.
Please correct me, if I am misunderstanding what you mean.

Thanks.


      reply	other threads:[~2021-08-30 11:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  5:44 sasaki tatsuya
2021-08-24 20:41 ` Sagi Grimberg
2021-08-25  8:26   ` sasaki tatsuya
2021-08-25  9:04   ` hch
2021-08-25  8:53 ` hch
2021-08-25 15:51   ` Hannes Reinecke
2021-08-30 11:27     ` sasaki tatsuya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ffa643335a9467ba586450f8820c54a@kioxia.com \
    --to=tatsuya6.sasaki@kioxia.com \
    --cc=axboe@fb.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome