From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CA2C388F7 for ; Thu, 22 Oct 2020 14:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 513762225F for ; Thu, 22 Oct 2020 14:22:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PnaNtzUx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368089AbgJVOWR (ORCPT ); Thu, 22 Oct 2020 10:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S368081AbgJVOWO (ORCPT ); Thu, 22 Oct 2020 10:22:14 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3807C0613CF for ; Thu, 22 Oct 2020 07:22:13 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id i12so1636994ota.5 for ; Thu, 22 Oct 2020 07:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nUipHJfv/EyGC6hg2VZD5Uc9VP53EEs7d0zZGl1sAVo=; b=PnaNtzUxmbf8rR2YXI90l/P+hxJBRLp5AFF5OwQFLEcr6BFSUqaMcA06n6gmAp2rVu zSP+qIA07nUxjGhBr+Cezhg2UgAJ2Gvomje8M+uu/4RQ1m9taD69bF7e6OtXqcOdgP79 iPzEYWNWQzZqHI31bfTD6qBUNzUZeKQqpSa+IWEmwMnpoZfc4SomjaRNdevVOw4Fu0n1 /zJvnrVASpt7dibPY+zzj+jcd0KXC4XzQ/lIQ7ciY59lYBdlQK3iNjuStKqA+lsPopkw jL7Jqe6T0mTtTLq6SxRDy6DtB5boYuRjdOAsKIW9Z3MDZlX2M7EhYtP9UBOyzWgkTJIN T5EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nUipHJfv/EyGC6hg2VZD5Uc9VP53EEs7d0zZGl1sAVo=; b=bZ90OZqQCSl6UpFZq2jsgtpsgJCzfPM3C9Y7Ck0US515NLwcg1gfuu5BFge7OsnOh9 J6BRijXzUyhYJpAGrhTwxlUxZMn70H+5jrPHL6b/Ny5cXhE9kxv0tttsormnEJ3xED2R NnRgjyJggMrIrgCsUX2m/yUaXKKDAAwRXpChQbRMUwyd2B26a8aKaB4RrgJ2TQuFch8t JIwyNhkNMfd67YXRtrx7EowlHKGt3PYDvs8p5R7S42C2dHRdMvkZCSnLCaptq+m1N/Ot R4+0ZL4mmlhQaQOZiZjZpWVjH8vGOsvC6HjvPwqOpfEblGkkI8UDh1z3OmSt5IYZ6G4g 58cw== X-Gm-Message-State: AOAM5328Ot4EAtLc/2glD97IrrtGhgdFEMJq9kFdvYUMlwH6CBesaaKC H6TqnVzf7s8HszxQpT0DOUDAhqqygcE= X-Google-Smtp-Source: ABdhPJxypVZFwqjCNPXq9kVFCscI5uH/NQlcd7pZx2VtJa4FJXK7+DZ6b09/9Dxp7ml5naxawxGndg== X-Received: by 2002:a9d:7f14:: with SMTP id j20mr2006766otq.69.1603376532902; Thu, 22 Oct 2020 07:22:12 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m18sm488863ooj.6.2020.10.22.07.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2020 07:22:12 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [RFC 1/2] printk: Add kernel parameter: mute_console To: Steven Rostedt , Petr Mladek Cc: Sergey Senozhatsky , John Ogness , Linus Torvalds , Shreyas Joshi , shreyasjoshi15@gmail.com, Greg Kroah-Hartman , Sergey Senozhatsky , linux-kernel@vger.kernel.org References: <20201022114228.9098-1-pmladek@suse.com> <20201022114228.9098-2-pmladek@suse.com> <20201022094512.37c9bf5d@gandalf.local.home> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <4ffbe1d1-ba44-c202-acc6-51979c39da75@roeck-us.net> Date: Thu, 22 Oct 2020 07:22:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201022094512.37c9bf5d@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/20 6:45 AM, Steven Rostedt wrote: > On Thu, 22 Oct 2020 13:42:27 +0200 > Petr Mladek wrote: > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> index fe64a49344bf..63fb96630767 100644 >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> @@ -1207,6 +1207,19 @@ void __init setup_log_buf(int early) >> memblock_free(__pa(new_log_buf), new_log_buf_len); >> } >> >> +static bool mute_console; >> + >> +static int __init mute_console_setup(char *str) >> +{ >> + mute_console = true; >> + pr_info("All consoles muted.\n"); >> + >> + return 0; >> +} >> + >> +early_param("mute_console", mute_console_setup); >> +module_param(mute_console, bool, 0644); >> + > > Why have both early_param and module_param? What's the purpose of > module_param? Usually that's there to just set a variable, without a need > for another interface. But if you have early_param() that sets > mute_console, isn't that redundant? > For me the question was why we would need an extra module parameter in the first place instead of just making "console=" and "console=null" official. It doesn't really matter for us as long as "console=" is still supported, I just don't see the point. Thanks, Guenter