From: Markus Elfring <Markus.Elfring@web.de>
To: Aleksandr Mishin <amishin@t-argos.ru>,
linux-acpi@vger.kernel.org, lvc-project@linuxtesting.org,
Rajmohan Mani <rajmohan.mani@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy@kernel.org>, Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] ACPI / PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()
Date: Sat, 6 Jul 2024 15:47:02 +0200 [thread overview]
Message-ID: <4ffe1d11-8442-40fc-bb93-581e9d1c93ab@web.de> (raw)
In-Reply-To: <20240705113434.17249-1-amishin@t-argos.ru>
> In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which
> is useless.
because …?
> Fix this issue by removing unneeded check.
Another wording suggestion:
Thus remove a redundant check (and …?).
…
> +++ b/drivers/acpi/pmic/tps68470_pmic.c
> @@ -376,7 +376,7 @@ static int tps68470_pmic_opregion_probe(struct platform_device *pdev)
> struct tps68470_pmic_opregion *opregion;
> acpi_status status;
>
> - if (!dev || !tps68470_regmap) {
> + if (!tps68470_regmap) {
> dev_warn(dev, "dev or regmap is NULL\n");
…
Would you like to adjust the passed string literal accordingly?
Regards,
Markus
next prev parent reply other threads:[~2024-07-06 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 11:34 Aleksandr Mishin
2024-07-06 11:56 ` Sakari Ailus
2024-07-06 13:47 ` Markus Elfring [this message]
2024-07-30 19:38 ` Andy Shevchenko
2024-07-30 22:53 ` [PATCH v2] " Aleksandr Mishin
2024-07-31 7:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ffe1d11-8442-40fc-bb93-581e9d1c93ab@web.de \
--to=markus.elfring@web.de \
--cc=amishin@t-argos.ru \
--cc=andy@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®