From: Grant Coady <grant_lkml@dodo.com.au>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Grant Coady <gcoady.lk@gmail.com>,
achim_leubner@adaptec.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GDT SCSI DISK ARRAY: fix split line comments for grep
Date: Sun, 03 Aug 2008 13:39:45 +1000 [thread overview]
Message-ID: <4v9a94lbmt1ript986mkbtgr1g6jffamnc@4ax.com> (raw)
In-Reply-To: <1217732421.30264.5.camel@localhost.localdomain>
On Sat, 02 Aug 2008 22:00:21 -0500, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>On Sun, 2008-08-03 at 08:44 +1000, Grant Coady wrote:
>> Hi there,
>>
>> Following patch unsplits some comment lines that hold driver device
>> names so they can be grepped.
>
>I don't actually see a problem to be fixed here. The original author
>obviously split the lines to be under 80 chars. The actual board names
>are still integral in the comments and thus greppable even for the split
>lines. What is it that you think needs to be fixed?
I suppose if you always grep with context there's no problem?
It's the only file I found with this issue while doing other stuff.
Grant.
prev parent reply other threads:[~2008-08-03 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 22:44 Grant Coady
2008-08-03 3:00 ` James Bottomley
2008-08-03 3:39 ` Grant Coady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4v9a94lbmt1ript986mkbtgr1g6jffamnc@4ax.com \
--to=grant_lkml@dodo.com.au \
--cc=James.Bottomley@HansenPartnership.com \
--cc=achim_leubner@adaptec.com \
--cc=gcoady.lk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®