Re: AX25/socket kernel PATCHes

[Henk de Groot <henk.de.groot@hetnet.nl>]

Hello Alan,

At 18:02 29-12-01 +0000, Alan Cox wrote:
>If you change
>
>                        if (skb2->nh.raw < skb2->data || skb2->nh.raw >= skb2->...
>                                if (net_ratelimit())
>
>So that it checks
>                        < skb2->data || nh.raw > ..
>
>Let me know if that fixes it. It shouldn't but it would be good to know if

I thought I understood but I'm not so sure anymore. I applied the following patch to dev.c:

--------------------------------------------------------------------------
--- linux/net/core/dev.c.orig   Sun Dec 30 00:31:43 2001
+++ linux/net/core/dev.c        Sun Dec 30 00:33:27 2001
@@ -940,7 +940,7 @@
                         */
                        skb2->mac.raw = skb2->data;
 
-                       if (skb2->nh.raw < skb2->data || skb2->nh.raw > skb2->tail) {
+                       if (skb2->nh.raw < skb2->data || nh.raw > skb2->tail) {
                                if (net_ratelimit())
                                        printk(KERN_DEBUG "protocol %04x is buggy, dev %s\n", skb2->protocol, dev->name);
                                skb2->nh.raw = skb2->data;
--------------------------------------------------------------------------

This however gives compilation errors, 'nh' undeclared. So no buggy messages anymore :-)...

It's easy for me to generate these buggy messages (each raw transmission seems to produce them) so if there is anything I can try out I'll be happy to do it.

Kind regards,

Henk.

P.S. I'm using a SuSE flavour of the kernel so I have to use the linux-2.4.16.tar.bz2 kernel with SuSE's suse-2.4.16-7.bz2 patches as there are no SuSE addaptations for the 2.4.17 kernel yet (at least last time I checked, i.e. yesterday).