From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"Andre M. Hedrick" <andre@linux-ide.org>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [patch] 2.5.3-pre1 ide updates
Date: Thu, 17 Jan 2002 14:29:49 +0000 [thread overview]
Message-ID: <5.1.0.14.2.20020117141843.02615430@pop.cus.cam.ac.uk> (raw)
In-Reply-To: <20020117144648.L20994@suse.de>
Hi Jens,
I think there is a bug here...
At 13:46 17/01/02, Jens Axboe wrote:
>diff -urN -X exclude /ata/linux-2.5.3-pre1/drivers/ide/ide-taskfile.c
>linux/drivers/ide/ide-taskfile.c
>--- /ata/linux-2.5.3-pre1/drivers/ide/ide-taskfile.c Thu Jan 17
>06:32:54 2002
>+++ linux/drivers/ide/ide-taskfile.c Thu Jan 17 06:29:13 2002
>@@ -994,10 +1032,11 @@
> if (!msect) {
> nsect = 1;
> while (rq->current_nr_sectors) {
>- pBuf = rq->buffer + ((rq->nr_sectors -
>rq->current_nr_sectors) * SECTOR_SIZE);
>+ pBuf = ide_unmap_buffer(rq, &flags);
That should be: pBuf = ide_map_buffer(rq, &flags);
But I think it actually ought to be:
pBuf = ide_map_rq(rq, &flags)
and the below unmap should consequently be:
ide_unmap_rq(rq, pBuf, &flags)
In either case it's wrong at the moment AFAICS...
> DTF("Multiwrite: %p, nsect: %d,
> rq->current_nr_sectors: %ld\n", pBuf, nsect, rq->current_nr_sectors);
> drive->io_32bit = 0;
> taskfile_output_data(drive, pBuf, nsect *
> SECTOR_WORDS);
>+ ide_unmap_buffer(pBuf, &flags);
> drive->io_32bit = io_32bit;
> rq->errors = 0;
> rq->current_nr_sectors -= nsect;
Best regards,
Anton
--
"I've not lost my mind. It's backed up on tape somewhere." - Unknown
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Linux NTFS Maintainer / WWW: http://linux-ntfs.sf.net/
ICQ: 8561279 / WWW: http://www-stu.christs.cam.ac.uk/~aia21/
next prev parent reply other threads:[~2002-01-17 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-17 13:46 Jens Axboe
2002-01-17 14:29 ` Anton Altaparmakov [this message]
2002-01-17 14:28 ` Jens Axboe
2002-01-17 14:29 ` Jens Axboe
2002-01-17 14:34 ` [PATCH] 2.5.3-pre1 ata-253p1-2 Jens Axboe
2002-01-17 22:16 ` Robert Love
2002-01-17 22:59 ` Andre Hedrick
2002-01-17 23:13 ` Robert Love
2002-01-18 1:00 ` Anton Altaparmakov
2002-01-18 7:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20020117141843.02615430@pop.cus.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®