From: Maksim Krasnyanskiy <maxk@qualcomm.com>
To: "David S. Miller" <davem@redhat.com>
Cc: rml@tech9.net, fisaksen@bewan.com, mitch@sfgoth.com,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br,
alan@redhat.com, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] ATM locking fix.
Date: Wed, 27 Mar 2002 17:55:50 -0800 [thread overview]
Message-ID: <5.1.0.14.2.20020327175258.08c69e70@mail1.qualcomm.com> (raw)
In-Reply-To: <20020326.145202.122762468.davem@redhat.com>
>I'm applying this patch with some minor cleanups of my own.
Ok. And don't forget a patch sent by Francois on top of mine.
>I went and then checked around for atm_find_dev() users to
>make sure they held the atm_dev_lock, and I discovered several pieces
>of "hidden treasure".
Hmm, I thought I check all of them.
>Firstly, have a look at net/atm/common.c:atm_ioctl() and how it
>accesses userspace while holding atm_dev_lock. That is just the
>tip of the iceberg.
Yeah, that's what I said from the very beginning. ATM locking is messed up.
Max
next prev parent reply other threads:[~2002-03-28 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-07 22:11 [PATCH] ATM locking fix. [Re: [PATCH] spinlock not locked when unlocking in atm_dev_register] Maksim Krasnyanskiy
2002-03-09 18:45 ` Francois Romieu
2002-03-11 18:38 ` Maksim Krasnyanskiy
2002-03-11 20:04 ` Francois Romieu
2002-03-26 22:52 ` [PATCH] ATM locking fix David S. Miller
2002-03-26 23:08 ` Dave Jones
2002-03-26 23:11 ` David S. Miller
2002-03-26 23:27 ` Mr. James W. Laferriere
2002-03-28 1:55 ` Maksim Krasnyanskiy [this message]
2002-03-28 1:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20020327175258.08c69e70@mail1.qualcomm.com \
--to=maxk@qualcomm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=davem@redhat.com \
--cc=fisaksen@bewan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=mitch@sfgoth.com \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®