mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maksim (Max) Krasnyanskiy" <maxk@qualcomm.com>
To: Marcel Holtmann <marcel@holtmann.org>, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH] Make it possible to compile in the Bluetooth subsystem
Date: Mon, 07 Oct 2002 15:40:40 -0700	[thread overview]
Message-ID: <5.1.0.14.2.20021007152433.08fac980@mail1.qualcomm.com> (raw)
In-Reply-To: <E17yelj-0005CD-00@pegasus>

Marcel,

>@@ -345,7 +345,7 @@
>         return 0;
>  }
>
>-static void __exit bluez_cleanup(void)
>+void __exit bluez_cleanup(void)
>  {
>         hci_sock_cleanup();
>         hci_core_cleanup();
>@@ -356,11 +356,9 @@
>         remove_proc_entry("bluetooth", NULL);
>  }
>
>-#ifdef MODULE
>  module_init(bluez_init);
>  module_exit(bluez_cleanup);
>
>  MODULE_AUTHOR("Maxim Krasnyansky <maxk@qualcomm.com>");
>  MODULE_DESCRIPTION("BlueZ Core ver " VERSION);
>  MODULE_LICENSE("GPL");
>-#endif
This is wrong. If Bluetooth is compiled in, bluez_init() is called from
linux/net/socket.c. We have to change that to subsys_initcall.

Linus, please don't apply. We'll send correct patch later.

Thanks
Max






      parent reply	other threads:[~2002-10-07 22:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-07 20:46 Marcel Holtmann
2002-10-07 20:49 ` Linus Torvalds
2002-10-07 20:51   ` Linus Torvalds
2002-10-07 21:24   ` Marcel Holtmann
2002-10-07 21:28     ` Linus Torvalds
2002-10-07 22:38       ` Marcel Holtmann
2002-10-07 22:40 ` Maksim (Max) Krasnyanskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.1.0.14.2.20021007152433.08fac980@mail1.qualcomm.com \
    --to=maxk@qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®