From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Feb 2003 12:57:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Feb 2003 12:57:32 -0500 Received: from ithilien.qualcomm.com ([129.46.51.59]:29312 "EHLO ithilien.qualcomm.com") by vger.kernel.org with ESMTP id ; Wed, 19 Feb 2003 12:57:31 -0500 Message-Id: <5.1.0.14.2.20030219094834.0d2123c0@mail1.qualcomm.com> X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Wed, 19 Feb 2003 10:03:30 -0800 To: "David S. Miller" , rusty@rustcorp.com.au From: Max Krasnyansky Subject: Re: [PATCH/RFC] New module refcounting for net_proto_family Cc: kuznet@ms2.inr.ac.ru, jt@bougret.hpl.hp.com, linux-kernel@vger.kernel.org In-Reply-To: <20030218.230402.113318233.davem@redhat.com> References: <20030219035559.7527A2C079@lists.samba.org> <5.1.0.14.2.20030218101309.048d4288@mail1.qualcomm.com> <20030219035559.7527A2C079@lists.samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At 11:04 PM 2/18/2003, David S. Miller wrote: > From: Rusty Russell > Date: Wed, 19 Feb 2003 14:54:21 +1100 > > Firstly, the owner field should probably be in struct proto_ops not > struct socket, where the function pointers are. > >I think this is one of Alexey's main problems with the patch. This is a bit more informative than "oh it's an ugly hack" ;-) Ok. I got at least three reasons why I think owner field should be in struct socket: - struct proto_ops doesn't exists without struct socket. It cannot be registered or otherwise used on it's own. - struct sock might inherit (when needed see my explanation about different families) its owner from struct socket. In which case sk_set_owner(sk, socket->ops->owner) doesn't look right. - we might want to protect something else besides socket->ops. None of those reasons are critical. If you guys still feel that ->owner must be in struct proto_ops be that way, I'm ok with it. Any other comments ? Alexey, this is the time for you to speak up ;-). Please please. So far I got zero feedback from you. And you are the one who somehow made DaveM radically change his mind :). Thanks Max