mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Max Krasnyansky <maxk@qualcomm.com>
To: Pavel Machek <pavel@ucw.cz>,
	kernel list <linux-kernel@vger.kernel.org>,
	torvalds@transmeta.com, ak@suse.de, davem@redhat.com
Subject: Re: ioctl32 consolidation
Date: Thu, 20 Feb 2003 14:56:22 -0800	[thread overview]
Message-ID: <5.1.0.14.2.20030220145240.0d449118@mail1.qualcomm.com> (raw)
In-Reply-To: <20030220223119.GA18545@elf.ucw.cz>

At 02:31 PM 2/20/2003, Pavel Machek wrote:
>Hi!
>
>Currently, 32-bit emulation in kernel has *5* copies, and its >1000
>lines each. Plus, locking of all but x86-64 architectures is broken
>(I'm told by andi ;-).
>
>So, here's patch that starts sharing sys32_ioctl() [as a first step],
>which should rmove locking problems.
>
>I've done the work for x86-64 and sparc64; if it looks good I'll
>attempt to do other architectures. [Unless maintainers prefer to do it
>themselves: I don't have easy access to 64-bit machines besides
>hammer.]

Nice. I'm glad that somebody started looking at this (I was going to work 
on that but didn't have time for it).
Patch looks ok to me.

Eventually we'll be able to kill ugly mess like arch/sparc64/kernel/ioctl32.c.
That stuff really belongs to the actual subsystems that implement those ioctls.

Thanks
Max


  parent reply	other threads:[~2003-02-20 22:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-20 22:31 Pavel Machek
2003-02-20 22:44 ` Jeff Garzik
2003-02-21 11:34   ` Pavel Machek
2003-02-21 11:58     ` Andi Kleen
2003-02-21 23:21     ` David S. Miller
2003-03-01 19:49     ` Anton Blanchard
2003-02-20 22:56 ` Max Krasnyansky [this message]
2003-02-20 23:10   ` Jeff Garzik
2003-02-21  0:36   ` David S. Miller
2003-02-21  1:31     ` Max Krasnyansky
2003-02-21  1:40       ` Jeff Garzik
2003-02-21  3:20       ` David S. Miller
     [not found] <20030221114011$5b98@gated-at.bofh.it>
     [not found] ` <20030221114011$7728@gated-at.bofh.it>
     [not found]   ` <20030221114011$25df@gated-at.bofh.it>
2003-02-21 22:27     ` Arnd Bergmann
2003-02-24 10:05 Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.1.0.14.2.20030220145240.0d449118@mail1.qualcomm.com \
    --to=maxk@qualcomm.com \
    --cc=ak@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®