From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbdKTPcP (ORCPT ); Mon, 20 Nov 2017 10:32:15 -0500 Received: from mout.web.de ([212.227.15.14]:64778 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdKTPcN (ORCPT ); Mon, 20 Nov 2017 10:32:13 -0500 To: Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Jiri Olsa , Namhyung Kim , Peter Zijlstra From: SF Markus Elfring Subject: [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config() Cc: David Ahern , Kan Liang , kernel-janitors@vger.kernel.org, LKML Message-ID: <50004e9c-14f8-5a01-fa96-001d32e7c2b2@users.sourceforge.net> Date: Mon, 20 Nov 2017 16:30:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:aThiEXtgcDgnhr1UhIFEF7ABIxeiOSm7LEfRlkHYKriJJ8KrrE+ GRKyZyCBOfhmuHqqH6/ccMkNQmNzuuTP0MEYlyYH6SuamionvkdNBjANPqetrqw2p/N36fK Q6FJ2hiysAM0UQPl7j9zkt0wnO29ZMekADXLzw63QSPerc+D6bOFjrVY+JVCsDCAPqt2Mw8 0ToWXaT1FAaP2avdzokvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:YgjYeUaY3Ys=:w242QT1cLIAcJBXy+N15J4 QA9BldeLYSXnh7ZhKWpsjOmO4XYgfEWz/72K6Q34Q6FSJY9B5rZocMD8Yr3Y7voU8x2T/KqdT mvCfhySZez2/PPTjoRcPra/+ZhxFEEMf04NpyitLQDNyYk9kpK+wZ+l/VWX/xYzMliFKtdWfD mKAKo5oZiiE9fGSTVXekLZlYHCQPtrfJrno/TgtNnEFzQLGOhwIuMcjZCDv+iX6nAl825v6JH rvXT5x6zhOp+CkoEUorhEipS6r+no587HkKZzBLI1FW/eWNmySbA9glb0mfL27FYYS/7v92UZ E5MrcJ64QRNQqfHgrI0BT6Y028pTkmh0G2ojzLgo4fYyUUuYFfOBzticWWdwMx1Csdcdd5q++ Khi7QSkZr+EiG9lzFnrTFHJvJYaCwhtvPLgAarMj4kkSuc42sTRfaT7AcPKawI8SHUpGAgdnZ axwMem8ne/M8IuIErdfntZICNNPYOjZT8kndimxPBJm/MoMETNuwNoqYogUWoTfgygDyKqZe+ 360YCg5f7XD4R3poBOWAxret+wR4ywtrXqe+72ij2AtKrF3RER9JISOk8lV9J+Mo9ham7c98J ki34OEEy1IBTRrIhoeFB+mg/CkBUoTDRXOkqRamIdoA9ExiD8tIvBeay5DC6vilkAi3iTi8Lv ny2LtyYe+P57hGyNE0G9qzYjXeHw0h5PPJJsIkiERAT2fqLszTyDdWYcGCVoMADFWRDWwPMDC l8fXIof14pjLJinc+M8oU4GoNJEVZvnE9hwIvaBu1B7VxjF9LPU88zpmidgINcFvK6HJ92pIL gaY09458nw7/tUQiAHt9Tzufsr+NVatRe+yui1basuoAT06fLSNfKg3fD9h3tOjx8t1RS4j Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 20 Nov 2017 15:55:25 +0100 Duplicate error messages were used so far in this function implementation. Make them unique instead. This issue was detected by using the Coccinelle software. Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events") Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data") Signed-off-by: Markus Elfring --- tools/perf/builtin-stat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 59af5a8419e2..ed0f23bb2230 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe) if (counter->own_cpus) { err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event); if (err < 0) { - pr_err("Couldn't synthesize evsel scale.\n"); + pr_err("Couldn't synthesize evsel CPUs.\n"); return err; } } @@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe) err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus, process_synthesized_event, NULL); if (err < 0) { - pr_err("Couldn't synthesize thread map.\n"); + pr_err("Couldn't synthesize CPU map.\n"); return err; } -- 2.15.0