From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbbJOTks (ORCPT ); Thu, 15 Oct 2015 15:40:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbJOTkq (ORCPT ); Thu, 15 Oct 2015 15:40:46 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1444926178-28856-1-git-send-email-wuninsu@gmail.com> <29544.1444935453@warthog.procyon.org.uk> To: Insu Yun Cc: dhowells@redhat.com, james.l.morris@oracle.com, serge@hallyn.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Taesoo Kim , Yeongjin Jang , "Yun, Insu" Subject: Re: [PATCH] keys: correctly check failed allocation for kmemdup MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5002.1444938039.1@warthog.procyon.org.uk> Date: Thu, 15 Oct 2015 20:40:39 +0100 Message-ID: <5003.1444938039@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Insu Yun wrote: > Thanks David. Then it is not a bug. > It's a pure question. > Why use different name for allocation and check? > For me, it is quite confusing. Either I didn't notice at the time, or the shorter variant is the original. If you want to give me a patch making it consistent, feel free. David