From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2AC30E0D5 for ; Fri, 2 Jan 2026 11:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767354379; cv=none; b=K12LrfJy2By10MuVgQ4qGAwO+eNiIxjxmqj5tQmpDis1UDb7/5nGfb2T2kdGBU7KN5PMeBtuleDIWYl7d5txZ6qed0i73H6+WlPYo4LNchefgWjxU8+MmFOQM5sXwRb4pfZYpbeHyvHPLIPSOlkn8ubAOVF8EdKNbT1SJ3Npy0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767354379; c=relaxed/simple; bh=Lamw3DKXd+EDOviZ694M+MoTo/Zzuhu3p+ZsGdJlG3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QtbfC8D02O7bZZsY3iL/IqHvOP0Pj4oKXDpWzyVHBDTQEWz2tV6u6iikr7YhbKnQj8tMDOIiAepaeCfPXSvJka9I4iOha2G5fkXNYW6/9UItb3ujNNoQitisyW0PmKcGGkGAt7697HVByLqdajqxgTyydlsLzpTFPHCrSG88KKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dHefxxyw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FPYlS3Wq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dHefxxyw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FPYlS3Wq" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029WFZJ824652 for ; Fri, 2 Jan 2026 11:46:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kIO0EifCFwMkzSgGMHO+rCSEYMs7exKLpIp2wnkEVM0=; b=dHefxxywzlSevP0J 7eFgtmERywp2yfD/gg8h9bG3eYaECvOT+/gAYoD/dkoFUMy2jeme2Ug4LMobT7oH xYKjCZTXM+DCtjmQMIb0++ySxvmhQJspuOVjutYvW4kMrMDUGNU4GynicWYcMg0k yYlkYPR0mPDHh9IFnsj3wAyfQq4RXA5zKhZXe9jBQB+iNO4e/1VUdIBGjQHbEFcf IxCyVNUvHMY1KBuPv1/KtsbWG62++s/U554ZEg2Xgu4ojuiCdZF4WqrDiWtOJwUg dS0gU1hFCAPdSPelF0DYjBykmW3Ws2d8zEpFithWVoQMiadx80W/1tIyGMN8J74g lVSYcw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bd85338kb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 11:46:15 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c5a2bd638so3829144a91.0 for ; Fri, 02 Jan 2026 03:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767354374; x=1767959174; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kIO0EifCFwMkzSgGMHO+rCSEYMs7exKLpIp2wnkEVM0=; b=FPYlS3WqL9dOgMEiTjLSy+RMajHraUiM+3hS0TAg/XZg9JBN+qGe6S3vJSOaIaZsxx VsBqNwmZRZeWBEsaa4XnMaoAWay3j21Tejl9r5SCnriLRnjQvrIuK5+gYxucG4Hjzh3x rFRjVyGE8OrgHHmQq6Rd3Wz96QLoYVQlQ0ZnKnSMJ27ncl9gqA5laRVye4N9LqIVx+Yh /NPnoRdxRqAqga3L6D7ovZ3HTyrpLVz0jwmpKK9vYcsWv0SdwKz1PEsTvCtFFFLzn+Ci fpe0dlG7LOSDzhqW9j1btZHxLnfN/Y2yN9MjTwCAWIZjublRsOlw1m/WeNU6uyhXaduR Ydqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767354374; x=1767959174; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kIO0EifCFwMkzSgGMHO+rCSEYMs7exKLpIp2wnkEVM0=; b=diPQ/+PGaEU0l0ZlSV4Fc/McNnAG0INRwQFkO/ll34r4Y2/O2TEmqAsigA1kIM7+D5 2vJVYljNTKBYNSSssfGJCZl/t8XtM4QAeFii7SGsfF5FUK6e0K8Il2Z7K3N0oYPOh/Zj W9/Kt6LRcDNpo+nPKKkHneTN5mzVypYO1m+eMMPmWQUbi6ZRSVYQLSKqviNcyBq9Sljf 9taHWNUFOzx4Vo9mp4LQfxvOXvaFG/Zaxfr0R+sVtxeR754EVd6FUDd/5aFAtuLg1FMm I/s52k2ndGkFZWvoUQuy5bZwfvtjAKpCGj543oF+PdMOSEZAR4/GZj8RqWlIYWmuaRR+ qqCw== X-Forwarded-Encrypted: i=1; AJvYcCXeyLfHCQXGO+qhE8M2tI9eoIWtzHjBXXX94mnW5c9/bhLTzIH86/YingwGuILG1GVfGyhuMDS6rU56OEM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywwe2nVUrl4EmxhkZf7weSgAgD3U2dw3ZKziieAO7e+Z67h1GuT jpXzGmLT+/5gV/ncPkfybQqyG3y21Z9NXuShuTRqT0G5K2KYDsIDK0LA2lpY5Lg3aIKoWoZTdsM JPovK6aAzoc1UhcU5gYI/pkVPFv9y0kGIsFnUfvWK8f7wxAr1H2EdNDyeuipe6fvqm8Y= X-Gm-Gg: AY/fxX4XA9z4LMsdm02/lpV+2+xJvvySRLthzHxaU4f7ZEZE38ca+Kj+tkC56FgTmbh VHH5a6ByFGgFsixJ3WX3FMLBKpwq2toAzDhJhzG8HJdT6lUDABzXOu/ep+Fnau+29zDUFysm5Ha pAjQeYkEQFGRwMn1y+qy+AVnXHJRT2L4XfPnJc+7TgDP9HN2kSyQTb7WvTf2Jp1vso7nUVEtA1Y tefkXw0yBuH/HkHP0Uydq72HJJMkcDiTVR59WKWOGeM5SXwX5tw0SWd/bGJFZi/ppTvk9TPIC3g yDr46hDnNA4hW0OopH+Ay/bMf0X1WCL4XanZhRdNGHMoSxO1+negv6adv0vw2vhvnb2J/gLtq/D K4ZLEc7peGepM/eQcB56CezxxDSnI8rFKjaVv+hL8p0f19cAVUE/n4sdQ+oUro0IcpQ== X-Received: by 2002:a05:6a21:3991:b0:366:26a6:2272 with SMTP id adf61e73a8af0-376aa8f2a34mr28536028637.5.1767354374523; Fri, 02 Jan 2026 03:46:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqC7FQ6GbGdskiziKH9KoPRNUzbvPPHDM7UoIxaE7VEz2xVwqVZu1iN1rEGBXjnHPl0XojIw== X-Received: by 2002:a05:622a:4d:b0:4f1:b3c1:20f8 with SMTP id d75a77b69052e-4f4abd30b01mr485697951cf.4.1767353999041; Fri, 02 Jan 2026 03:39:59 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8350268f86sm2242554966b.16.2026.01.02.03.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jan 2026 03:39:58 -0800 (PST) Message-ID: <500313f1-51fd-450e-877e-e4626b7652bc@oss.qualcomm.com> Date: Fri, 2 Jan 2026 12:39:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] clk: qcom: gcc: Do not turn off PCIe GDSCs during gdsc_disable() To: Krishna Chaitanya Chundru , Bjorn Andersson , Michael Turquette , Stephen Boyd , Taniya Das , Konrad Dybcio , Bartosz Golaszewski , Shazad Hussain , Sibi Sankar , Bryan O'Donoghue , Melody Olvera , Dmitry Baryshkov , Taniya Das , Dmitry Baryshkov , Imran Shaik , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , manivannan.sadhasivam@oss.qualcomm.com, stable@vger.kernel.org References: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: pMeiLyHlcLZPpj57jjWQjp13rp6jiM0Y X-Authority-Analysis: v=2.4 cv=fL80HJae c=1 sm=1 tr=0 ts=6957b007 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7LOYavHzeLgoFMqDmi4A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: pMeiLyHlcLZPpj57jjWQjp13rp6jiM0Y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDEwNCBTYWx0ZWRfX/BoKDojDehmf xftkRPnhfdWgzLvMuo52vxbHrJBBXICkIJb0dqMoZTGxkkOXtHreSk9FCFsXKSWQOGwJDlDs1U9 7xrzxMYy3857WRJ8QzaPPV8X/qNgKt+FifBK54hs4Ps4Y7gawC8zDpdwdy/HcbVGoQZx1POzcr+ tYeMUZTllDSuERkJWNAaaO+zPNNYAwepoG3ndmf0k4dhS4GGeUvPST9ZjtY4RKa8/U0yFU5fyQf NOwKbypPWxvJfnjH00Io1jD1xEAoQehSSyT4tEo4waCq4QOumS3lpvChVNrxCzhl+6OUdlL6YKe T8L+3HHOxNQnY7t/fPQxjJ9DnAinktJXIxPnDilBN95gK8w7kGeRxKCLwV79rD6rDIyvcowjRqc rzsa3gi0MUdIx2OoVEPGWkQgUGQCsiZW4o0yyHBGD/bbiWRQLJx3QZg5VOVI2MUl8u31XyvyTgs Pg9mv+dBb+Y5Ze0C6yg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-02_01,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020104 On 1/2/26 12:36 PM, Krishna Chaitanya Chundru wrote: > > > On 1/2/2026 5:04 PM, Konrad Dybcio wrote: >> On 1/2/26 10:43 AM, Krishna Chaitanya Chundru wrote: >>> With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This >>> can happen during scenarios such as system suspend and breaks the resume >>> of PCIe controllers from suspend. >> Isn't turning the GDSCs off what we want though? At least during system >> suspend? > If we are keeping link in D3cold it makes sense, but currently we are not keeping in D3cold > so we don't expect them to get off. Since we seem to be tackling that in parallel, it seems to make sense that adding a mechanism to let the PCIe driver select "on" vs "ret" vs "off" could be useful for us FWIW I recall I could turn off the GDSCs on at least makena with the old suspend patches and the controllers would come back to life afterwards Konrad