From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770AbbCSLIo (ORCPT ); Thu, 19 Mar 2015 07:08:44 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:56310 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752002AbbCSLIj (ORCPT ); Thu, 19 Mar 2015 07:08:39 -0400 From: "Rafael J. Wysocki" To: Mika Westerberg , Feng Kan , tj@kernel.org Cc: patches@apm.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH RESEND] sata: xgene: add ACPI support for APM X-Gene SATA ports Date: Thu, 19 Mar 2015 12:32:33 +0100 Message-ID: <5003912.K8jaqGYKiW@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150319095850.GO2165@lahna.fi.intel.com> References: <1426723435-22378-1-git-send-email-fkan@apm.com> <20150319095850.GO2165@lahna.fi.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, March 19, 2015 11:58:50 AM Mika Westerberg wrote: > On Wed, Mar 18, 2015 at 05:03:55PM -0700, Feng Kan wrote: > > This adds ACPI support for the APM X-Gene SATA ports. When the system > > boots using ACPI table, the SATA ports are able to configure using the > > values supplied by the ACPI table rather than the DTS. > > > > Signed-off-by: Feng Kan > > Reviewed-by: Hanjun Guo > > One minor comment, see below. Other than that this looks good to me: > > Reviewed-by: Mika Westerberg Thanks Mika! So for the patch Acked-by: Rafael J. Wysocki > > --- > > drivers/ata/ahci_xgene.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c > > index 2e8bb60..2b78510 100644 > > --- a/drivers/ata/ahci_xgene.c > > +++ b/drivers/ata/ahci_xgene.c > > @@ -22,6 +22,7 @@ > > * NOTE: PM support is not currently available. > > * > > */ > > +#include > > #include > > #include > > #include > > @@ -718,6 +719,14 @@ disable_resources: > > return rc; > > } > > > > +#ifdef CONFIG_ACPI > > +static const struct acpi_device_id xgene_ahci_acpi_match[] = { > > + { "APMC0D0D", }, > > I think writing the above without comma would look better: > > { "APMC0D0D" }, > > > > + { } > > +}; > > +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match); > > +#endif > > + > > static const struct of_device_id xgene_ahci_of_match[] = { > > {.compatible = "apm,xgene-ahci"}, > > {}, > > @@ -730,6 +739,7 @@ static struct platform_driver xgene_ahci_driver = { > > .driver = { > > .name = DRV_NAME, > > .of_match_table = xgene_ahci_of_match, > > + .acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match), > > }, > > }; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.