Re: [PATCH 01/90] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper

[Ian Abbott <abbotti@mev.co.uk>]

On 2012-07-19 02:24, H Hartley Sweeten wrote:
> Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
> to store the pci_dev pointer in the comedi_device hw_dev variable and
> retrieve it easily.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   drivers/staging/comedi/comedidev.h | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index de8c99c..620222d 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -446,6 +446,11 @@ static inline void comedi_set_hw_dev(struct comedi_device *dev,
>   	}
>   }
>
> +static inline struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev)
> +{
> +	return to_pci_dev(dev->hw_dev);
> +}
> +

That needs to be something like:

	return dev->hw_dev ? to_pci_dev(dev->hw_dev) : NULL;

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-