From: Carsten Emde <C.Emde@osadl.org>
To: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cc: Len Brown <len.brown@intel.com>, Kevin Hilman <khilman@ti.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 1/1 v3] Honor state disabling in the cpuidle ladder governor - with sanitizer
Date: Thu, 19 Jul 2012 13:39:31 +0200 [thread overview]
Message-ID: <5007F1F3.9090706@osadl.org> (raw)
In-Reply-To: <5007EC10.1060508@linux.vnet.ibm.com>
Deepthi,
>>> [..]
>>>> I could implement a sanitize mechanism of the ladder governor that
>>>> takes care the "disable" variables of all deeper states are set to 1,
>>>> if a state is disabled, and those of all lighter states are set to 0,
>>>> if a state is enabled. Do you wish me to do that?
>>> No, I dont think thats necessary, current code suffices it.
>>> The disable flag is knob we are giving to the user . So may be just
>>> document the intended use of disable flag working
>>> alongside design of ladder governor.
>> It's not necessary - but maybe better. Here comes v3 with a sanitizer.
>> Is this too ugly?
> The v2, with the documentation in place seems sufficient.
> Yup, this adds unnecessary fields which are not much use
> coz the same can be achieved with just disable flag check.
ok, let's take v2.
> Also, any reason why the patch is being sent as an attachment ?
> Sending patches as an attachment is not a recommended practice.
Sorry.
-Carsten.
next prev parent reply other threads:[~2012-07-19 11:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 18:59 [PATCH 0/1] cpuidle: allow to disable C states of the ladder governor Carsten Emde
2012-07-17 18:59 ` [PATCH 1/1] Honor state disabling in the cpuidle " Carsten Emde
2012-07-18 6:36 ` Deepthi Dharwar
2012-07-18 11:02 ` Carsten Emde
2012-07-18 11:48 ` Deepthi Dharwar
2012-07-18 14:09 ` [PATCH 1/1 v2] Honor state disabling in the cpuidle ladder governor - documented Carsten Emde
2012-07-18 14:38 ` [PATCH 1/1 v3] Honor state disabling in the cpuidle ladder governor - with sanitizer Carsten Emde
2012-07-19 11:14 ` Deepthi Dharwar
2012-07-19 11:39 ` Carsten Emde [this message]
2012-07-19 18:42 ` Rafael J. Wysocki
2012-07-19 18:52 ` [PATCH 0/1 v2] cpuidle: allow to disable C states of the ladder governor Carsten Emde
2012-07-19 18:52 ` [PATCH 1/1 v2] Honor state disabling in the cpuidle " Carsten Emde
2012-07-19 19:30 ` Rafael J. Wysocki
2012-07-19 20:34 ` [PATCH 0/1 v3] cpuidle: allow to disable C states of the " Carsten Emde
2012-07-19 20:34 ` [PATCH 1/1 v3] Honor state disabling in the cpuidle " Carsten Emde
2012-07-19 21:48 ` Rafael J. Wysocki
2012-07-19 22:22 ` Carsten Emde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007F1F3.9090706@osadl.org \
--to=c.emde@osadl.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome