From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754332Ab2GSLqu (ORCPT ); Thu, 19 Jul 2012 07:46:50 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:44522 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753977Ab2GSLqp (ORCPT ); Thu, 19 Jul 2012 07:46:45 -0400 Message-ID: <5007F39F.1020601@mev.co.uk> Date: Thu, 19 Jul 2012 12:46:39 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120616 Thunderbird/13.0 MIME-Version: 1.0 To: H Hartley Sweeten CC: Linux Kernel , "devel@driverdev.osuosl.org" , Ian Abbott , "gregkh@linuxfoundation.org" Subject: Re: [PATCH 65/90] staging: comedi: dt3000: cleanup "find pci device" code References: <201207181857.50208.hartleys@visionengravers.com> In-Reply-To: <201207181857.50208.hartleys@visionengravers.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012-07-19 02:57, H Hartley Sweeten wrote: > The "find pci device" code for this driver was split between > two functions which could cause the driver to walk the pci > bus multiple times while looking for a match. Actually the original version only walks through the PCI devices once (due to the `from` parameter in dt_pci_find_device()), but your version is cleaner. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-