mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Azhar Shaikh <azhar.shaikh@intel.com>,
	bleung@chromium.org, groeck@chromium.org,
	heikki.krogerus@linux.intel.com, pmalani@chromium.org
Cc: linux-kernel@vger.kernel.org, rajmohan.mani@intel.com,
	utkarsh.h.patel@intel.com, casey.g.bowman@intel.com
Subject: Re: [PATCH v4 0/3] TypeC Connector Class driver improvements
Date: Fri, 21 Aug 2020 09:13:13 +0200	[thread overview]
Message-ID: <5010d4f3-ac59-2a06-051c-83c8a51c3f4b@collabora.com> (raw)
In-Reply-To: <20200820233833.4551-1-azhar.shaikh@intel.com>

Hi Azhar,

I got a merge conflict because I applied [1] before these patches, fix the
conflict is trivial but, as I can't test, can you rebase your patches on top of
[1] and test and resend to make sure everything is working?

Thanks,
 Enric

[1] https://lkml.org/lkml/2020/7/10/1063


On 21/8/20 1:38, Azhar Shaikh wrote:
> Changes in v4:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
>             usb_role_switch_set_role()"
>   - Remove extra line between Fixes and Signed-off tag.
>   - Added Reviewed-by and Cc tags from v1 and v2.
> 
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
>             during disconnect"
>   - Added Suggested-by from v2.
> 
> * Patch 3: "platform/chrome: cros_ec_typec: Re-order connector
>             configuration steps"
>   - No change
> 
> Changes in v3:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
>             usb_role_switch_set_role()"
>  - No change
> 
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
>             during disconnect"
>  - Move the location of calling usb_role_switch_set_role() to
>    end of function in cros_typec_configure_mux() to avoid any change
>    in code flow.
> 
> * Patch 3: "platform/chrome: cros_ec_typec: Re-order connector
>             configuration steps"
>  - New patch added
> 
> Changes in v2:
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
>             usb_role_switch_set_role()"
>   - Update the commit message to change 'USB_ROLE_HOST in case of
>     UFP.'  to 'USB_ROLE_HOST in case of DFP.'
> 
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice
>             during disconnect"
>   - New patch added.
> 
> Azhar Shaikh (3):
>   platform/chrome: cros_ec_typec: Send enum values to
>     usb_role_switch_set_role()
>   platform/chrome: cros_ec_typec: Avoid setting usb role twice during
>     disconnect
>   platform/chrome: cros_ec_typec: Re-order connector configuration steps
> 
>  drivers/platform/chrome/cros_ec_typec.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

  parent reply	other threads:[~2020-08-21  7:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 23:38 Azhar Shaikh
2020-08-20 23:38 ` [PATCH v4 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role() Azhar Shaikh
2020-08-20 23:38 ` [PATCH v4 2/3] platform/chrome: cros_ec_typec: Avoid setting usb role twice during disconnect Azhar Shaikh
2020-08-20 23:38 ` [PATCH v4 3/3] platform/chrome: cros_ec_typec: Re-order connector configuration steps Azhar Shaikh
2020-08-21  0:01   ` Prashant Malani
2020-08-21  7:13 ` Enric Balletbo i Serra [this message]
2020-08-21 13:34   ` [PATCH v4 0/3] TypeC Connector Class driver improvements Shaikh, Azhar
2020-08-21 13:36     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5010d4f3-ac59-2a06-051c-83c8a51c3f4b@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=azhar.shaikh@intel.com \
    --cc=bleung@chromium.org \
    --cc=casey.g.bowman@intel.com \
    --cc=groeck@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=rajmohan.mani@intel.com \
    --cc=utkarsh.h.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®