From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3991EC54EBD for ; Sun, 8 Jan 2023 14:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232883AbjAHOJr (ORCPT ); Sun, 8 Jan 2023 09:09:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbjAHOJo (ORCPT ); Sun, 8 Jan 2023 09:09:44 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF43F5A for ; Sun, 8 Jan 2023 06:09:43 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id j16so8855483edw.11 for ; Sun, 08 Jan 2023 06:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BUXuEljk/LxD9w4jO73XPIf1d37sjYsJSMSF4W9BlWA=; b=jnIkfCI95i8V+nhOhVF+virknHy12j6qhnbXrPZk0xrs5NiQXHAlDaz6em67jwTvtG GaFJY75ckI6IovPA2/darF2J5TUnJ6zPfl0nBbSzWc9epNb4ZbaPHesvi7NC3Fg49qdT TVYKm0zQWUdOQ3/7OjooICgHtMCLB4HGKzdMT+u+1ZX83qzfKAJzxqQoYzb6Wyl31cf1 DcN22nf1RMq1+b5lNNKNxNBw6k62guo1XcpfbFbKkD/1QTnaTAcPzyFY00jSe4dT6YcK bDszSGLDvwORmvMHZUenspf3XNs0sE3lmOocr+oltZEKQ/SQoYJFi+vMTaCkNnr771Fo lAiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BUXuEljk/LxD9w4jO73XPIf1d37sjYsJSMSF4W9BlWA=; b=yDjIgysr3ewEVjmGWfEliRrPiwn4yyN4mXnr6e+bVGtC+WgmvXHY9eyGiFLBRu/99P iZI8LfD/VbgMmyKcsonrfbneLfvOe8U9AeeyZxFMp2uJCA7Ymbaj8ImjRotqF6bqDs8u Mx1w7Nrztpfr+c7+kehAcy34+J2FzwKZvURmxrVlKDGZ8Tz4flHU3W7Y0h8rV4ybFgG+ DRNyp508wWuWD1Kjz+BWM5aeSl1APH5v2Si4Al4ncCrAdGL/5BIqmN32AJ/0beAZgr4f O2GdX8FvlA4c3EJhIp/ybh9g8DRVGKiP2P9xZLJOwXXKoJGN8dr6gzstm1YHTBQsV0oS Sseg== X-Gm-Message-State: AFqh2kpGCMZ+5jXXOtjuPjmT/0T6Ht+450zRgsqwA1zYMy+1/TV6Z92I JBcTr5gG2rabjsUDkL7HM7w= X-Google-Smtp-Source: AMrXdXvYiQlOR+JD4TwSmEN10aKOeP2vFwYvzmplnw/e2DJDGRW3IYF9i+EGVlRNTAgKnEAvZUcw6w== X-Received: by 2002:a05:6402:5cf:b0:48d:3975:2d98 with SMTP id n15-20020a05640205cf00b0048d39752d98mr6314819edx.2.1673186981773; Sun, 08 Jan 2023 06:09:41 -0800 (PST) Received: from ?IPV6:2003:c7:8f35:4b95:4409:6ca5:4fd4:216b? (p200300c78f354b9544096ca54fd4216b.dip0.t-ipconnect.de. [2003:c7:8f35:4b95:4409:6ca5:4fd4:216b]) by smtp.gmail.com with ESMTPSA id x13-20020aa7cd8d000000b0047e6fdbf81csm2572702edv.82.2023.01.08.06.09.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jan 2023 06:09:41 -0800 (PST) Message-ID: <50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com> Date: Sun, 8 Jan 2023 15:09:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and NumTotalRFPath To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/3/23 09:30, Dan Carpenter wrote: > On Thu, Dec 29, 2022 at 05:25:46PM +0100, Philipp Hortmann wrote: >> Rename variable TSSI_13dBm to tssi_13dbm > > I would probably have kept this one as-is. It's not CamelCase, it's the > correct way to capitalize it. > > regards, > dan carpenter > Hi Dan, sorry for late. No issue with keeping this variable as is. But can you tell me the rule for the rest of the variables in this driver? Here just some examples: (I know that checkpatch is not always right) CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Are those OK as well? I would like to do it the right way. I do not want to discuss every variable change. Thanks for your support. Bye Philipp