From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543Ab2GZOvW (ORCPT ); Thu, 26 Jul 2012 10:51:22 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:51781 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814Ab2GZOvU (ORCPT ); Thu, 26 Jul 2012 10:51:20 -0400 Message-ID: <50115961.6060509@linaro.org> Date: Thu, 26 Jul 2012 15:51:13 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, sameo@linux.intel.com, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 07/21] ASoC: io: Prevent use of regmap if request fails References: <1343298534-13611-1-git-send-email-lee.jones@linaro.org> <1343298534-13611-8-git-send-email-lee.jones@linaro.org> <20120726113204.GY3099@opensource.wolfsonmicro.com> <50112C29.6020606@linaro.org> <20120726114215.GB3099@opensource.wolfsonmicro.com> In-Reply-To: <20120726114215.GB3099@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/07/12 12:42, Mark Brown wrote: > On Thu, Jul 26, 2012 at 12:38:17PM +0100, Lee Jones wrote: >> On 26/07/12 12:32, Mark Brown wrote: > >>> Again, this makes no sense. If we're explicitly being asked to use >>> regmap then we should be using regmap or just failing to set up I/O >>> (which is obviously a catastrophic failure). > >> How much work is there involved in regmap:ing a device, so that >> dev_get_regmap() doesn't fail? > > Trivial if it's on a supported bus, otherwise you just need to write the > bus. But why do you care if dev_get_regmap() fails? We only try to use > regmap if the driver asked for regmap I/O (or doesn't have registers at > all in which case it doesn't matter since we never do any I/O). What > you appear to be saying here is that you're using regmap on a device > which doesn't have a regmap set up which is clearly never going to work > terribly well... I don't think we want to use regmap at all, but we're forced to by soc-core. How do we over-ride that behavior? By writing some nonsense into codec->control_data? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog