From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322Ab2GZOzv (ORCPT ); Thu, 26 Jul 2012 10:55:51 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:48493 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130Ab2GZOzu (ORCPT ); Thu, 26 Jul 2012 10:55:50 -0400 Message-ID: <50115A73.10603@linaro.org> Date: Thu, 26 Jul 2012 15:55:47 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, sameo@linux.intel.com, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 17/21] ASoC: Ux500: Enable ux500 PCM driver for Device Tree References: <1343298534-13611-1-git-send-email-lee.jones@linaro.org> <1343298534-13611-18-git-send-email-lee.jones@linaro.org> <20120726113838.GA3099@opensource.wolfsonmicro.com> <50114B89.7070100@linaro.org> <20120726142225.GJ3099@opensource.wolfsonmicro.com> In-Reply-To: <20120726142225.GJ3099@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/07/12 15:22, Mark Brown wrote: > On Thu, Jul 26, 2012 at 02:52:09PM +0100, Lee Jones wrote: >> On 26/07/12 12:38, Mark Brown wrote: > >>>> - pr_info("%s: Register platform-device 'ux500-pcm'\n", __func__); >>>> - platform_device_register(&ux500_pcm); > >>> This has the same issue as your last patch... the way you're doing >>> things will break audio on all boards using this driver. > >> It will, why? > > You've just removed registration of the device and not added anything > else to replace that. Even if all boards convert to DT their DTs will > need to be updated which you're not doing. The initialisation function which calls platform_device_register() is only executed during a DT boot. The clue is in the title mop500_of_msp_init(). The DT is populated _before_ this patch, but I guess you mean if they are separated into subsystem trees and are placed into -next/Mainline out of order. I will merge these patches with the DT population instead to overcome this possibility. It makes more sense to keep the arch/arm stuff together in any case. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog