From: Marek Vasut <marex@denx.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Yassine Oudjana <yassine.oudjana@gmail.com>
Cc: "MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Yassine Oudjana" <y.oudjana@protonmail.com>
Subject: Re: [PATCH v2] extcon: usbc-tusb320: Call the Type-C IRQ handler only if a port is registered
Date: Mon, 7 Nov 2022 18:58:15 +0100 [thread overview]
Message-ID: <50130fa2-e15a-a043-94c8-002ac0817135@denx.de> (raw)
In-Reply-To: <Y2kyJqfhB4DXt7Te@kuha.fi.intel.com>
On 11/7/22 17:28, Heikki Krogerus wrote:
> On Mon, Nov 07, 2022 at 06:33:17PM +0300, Yassine Oudjana wrote:
>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>>
>> Commit bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> added an optional Type-C interface to the driver but missed to check
>> if it is in use when calling the IRQ handler. This causes an oops on
>> devices currently using the old extcon interface. Check if a Type-C
>> port is registered before calling the Type-C IRQ handler.
>>
>> Fixes: bf7571c00dca ("extcon: usbc-tusb320: Add USB TYPE-C support")
>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Looks good to me. FWIW:
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Likewise, looks good. You already have my RB. Thanks !
prev parent reply other threads:[~2022-11-07 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:33 Yassine Oudjana
2022-11-07 16:28 ` Heikki Krogerus
2022-11-07 17:58 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50130fa2-e15a-a043-94c8-002ac0817135@denx.de \
--to=marex@denx.de \
--cc=alsi@bang-olufsen.dk \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®