Re: [PATCH] staging:net:fixed to fit tty_driver's kref field

[Jiri Slaby <jslaby@suse.cz>]

On 07/29/2012 10:40 AM, Baodong Chen wrote:
> Fixed code to fix tty_driver's kref field
> checkpatch.pl clean up
> Signed-off-by: Baodong Chen <chenbdchenbd@gmail.com>

NACK. Please read Documentation/SubmittingPatches first.

This is an unreviewable patch. You do too many diverse changes in one
patch. Make your changes separate.

> ---
>  drivers/staging/net/pc300_tty.c |  763 ++++++++++++++++++++-------------------
>  1 files changed, 386 insertions(+), 377 deletions(-)
> 
> diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net/pc300_tty.c
> index 4709f42..859f680 100644
> --- a/drivers/staging/net/pc300_tty.c
> +++ b/drivers/staging/net/pc300_tty.c
> @@ -9,7 +9,7 @@
>   *  modify it under the terms of the GNU General Public License
>   *  as published by the Free Software Foundation; either version
>   *  2 of the License, or (at your option) any later version.
> - *   
> + *
>   *  $Log: pc300_tty.c,v $
>   *  Revision 3.7  2002/03/07 14:17:09  henrique
>   *  License data fixed
...

regards,
-- 
js
suse labs