From: Dan Carpenter <dan.carpenter@linaro.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] PCI: dwc: Fix a 64bit bug in dw_pcie_ep_raise_msix_irq()
Date: Fri, 19 Jan 2024 11:25:51 +0300 [thread overview]
Message-ID: <501533ad-7671-46aa-a034-91e0a6322e6c@moroto.mountain> (raw)
In-Reply-To: <ZahE455neE3wPnHA@x1-carbon>
On Wed, Jan 17, 2024 at 09:21:41PM +0000, Niklas Cassel wrote:
> Hello Dan,
>
> On Wed, Jan 17, 2024 at 09:32:08PM +0300, Dan Carpenter wrote:
> > The "msg_addr" variable is u64. However, the "tbl_offset" is an unsigned
>
> Here you write tbl_offset.
>
> > int. This means that when the code does
> >
> > msg_addr &= ~aligned_offset;
> >
> > it will unintentionally zero out the high 32 bits. Declare "tbl_offset"
>
> Here you also write tbl_offset.
>
That's so weird... I can't imagine how that happened. Do you think it
could be a Welsh mice situation where forest creatures are changing my
work when I'm away from my desk? https://www.youtube.com/shorts/h8gkIbtaaek
Fixed in v2. Thanks!
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-19 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 18:32 Dan Carpenter
2024-01-17 21:21 ` Niklas Cassel
2024-01-19 8:25 ` Dan Carpenter [this message]
2024-01-19 12:06 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501533ad-7671-46aa-a034-91e0a6322e6c@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Niklas.Cassel@wdc.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®