mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Luka Pivk <luka.pivk@toradex.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Stefan Agner <stefan.agner@toradex.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/3] regulator: fixed: add possibility to enable by clock
Date: Mon, 7 Oct 2019 07:25:43 -0700	[thread overview]
Message-ID: <50190291-7146-5a2d-e4ae-c08c3de553d3@roeck-us.net> (raw)
In-Reply-To: <3072f9de201a9d06cb0b71018be25f316c3d4435.camel@toradex.com>

On 10/7/19 6:57 AM, Philippe Schenker wrote:
> On Mon, 2019-10-07 at 06:29 -0700, Guenter Roeck wrote:
>> On Tue, Sep 10, 2019 at 06:21:15AM +0000, Philippe Schenker wrote:
>>> This commit adds the possibility to choose the compatible
>>> "regulator-fixed-clock" in devicetree.
>>>
>>> This is a special regulator-fixed that has to have a clock, from
>>> which
>>> the regulator gets switched on and off.
>>>
>>> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
>>
>> This patch causes a crash in one of my qemu tests (kzm machine with
>> imx_v6_v7_defconfig). Reverting this patch fixes the problem.
>> Crash backtrace and bisect log attached below.
>>
>> Guenter
> 
> Axel Lin sent a patch to fix this NULL pointer issue with my patch
> (Thanks by the way :)). I guess it will help for your issue. Could you
> please test if this patch solves your issue?
> 

Yes, it does. I replied with Tested-by: on the fixup patch.

Thanks,
Guenter

  reply	other threads:[~2019-10-07 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  6:21 [PATCH v2 0/3] Add new binding regulator-fixed-clock to regulator-fixed Philippe Schenker
2019-09-10  6:21 ` [PATCH v2 1/3] regulator: fixed: add possibility to enable by clock Philippe Schenker
2019-10-07 13:29   ` Guenter Roeck
2019-10-07 13:57     ` Philippe Schenker
2019-10-07 14:25       ` Guenter Roeck [this message]
2019-09-10  6:21 ` [PATCH v2 2/3] ARM: dts: imx6ull-colibri: add phy-supply and respective regulator Philippe Schenker
2019-09-10  6:21 ` [PATCH v2 3/3] dt-bindings: regulator: add regulator-fixed-clock binding Philippe Schenker
2019-09-10  8:35   ` Rob Herring
2019-09-17 20:13   ` Rob Herring
2019-09-23  6:58     ` Philippe Schenker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50190291-7146-5a2d-e4ae-c08c3de553d3@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luka.pivk@toradex.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=max.krummenacher@toradex.com \
    --cc=philippe.schenker@toradex.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan.agner@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®