From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4B8C77B75 for ; Fri, 5 May 2023 18:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233390AbjEESyh (ORCPT ); Fri, 5 May 2023 14:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233379AbjEESya (ORCPT ); Fri, 5 May 2023 14:54:30 -0400 Received: from smtpout.efficios.com (unknown [IPv6:2607:5300:203:b2ee::31e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DAA9226AE; Fri, 5 May 2023 11:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1683312862; bh=X3mGffREaWVeATl3zMMUiUzS4LSvCI/gVo9z8P7mjRk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LEFsNIIr+Duxnv3+wGVwXtrVVO/Rc894j1ZO30NrKlGwyJbjC1IYhwi7fYTxGbuuc guRAj2p1iGiMcfckbwVBs5ojUMM84O1Jm8kIqKPAgzUAviT4EE+KnvhSbsxDUcRkUV JuDrZJfwvu+LP03tykx+8Mte7uATOB1/QLlpsP1fATcLuPkSU5qdvqrbNfsZPgHocz JnbRm2UTXepM5RPFvvTFcxUPPYoxXE1oQqaLYwILhM5GFQHEMm738BzofX+MsIGbP7 Tz9lTH+TezejkYOJUjzTXykz3BcL1VpgGrJDg/oUzZx8odRvTfQetuM3k+ZelR/1/9 2lEDG+8yArw5A== Received: from [172.16.0.99] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4QCfxB21Q4z11ZT; Fri, 5 May 2023 14:54:22 -0400 (EDT) Message-ID: <501fdd3e-9f95-0d31-88c3-99f559118142@efficios.com> Date: Fri, 5 May 2023 14:54:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 11/13] netdevice.h: Fix parentheses around macro parameter use Content-Language: en-US To: Jakub Kicinski Cc: Andrew Morton , linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org References: <20230504200527.1935944-1-mathieu.desnoyers@efficios.com> <20230504200527.1935944-12-mathieu.desnoyers@efficios.com> <20230505114445.49082b62@kernel.org> From: Mathieu Desnoyers In-Reply-To: <20230505114445.49082b62@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-05-05 14:44, Jakub Kicinski wrote: > On Thu, 4 May 2023 16:05:25 -0400 Mathieu Desnoyers wrote: >> Add missing parentheses around macro parameter use in the following >> pattern: >> >> - "x - 1" changed for "(x) - 1", >> - "x->member" changed for "(x)->member". >> >> to ensure operator precedence behaves as expected. >> >> Remove useless parentheses around macro parameter use in the following >> pattern: >> >> - m((x), y) changed for m(x, y), because comma has the lowest operator >> precedence, which makes the extra comma useless. > > Sure, why not. Can we take it via netdev, tho? > I can't have any dependencies, right? I'll note your Acked-by in my patch for the next round. When I post without RFC tag it will be ready for merging. There is still some high-level feedback I want to gather on the overall series before I remove the RFC tag. There are no dependencies, each patch in this series only target a single header, and there are no dependencies across those patches. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com