From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754259AbdLHP4h (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Dec 2017 10:56:37 -0500
Received: from lelnx194.ext.ti.com ([198.47.27.80]:28674 "EHLO
        lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753954AbdLHP4d (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Dec 2017 10:56:33 -0500
Subject: Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node
To: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
        <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-leds@vger.kernel.org>
References: <20171208155514.7696-1-dmurphy@ti.com>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <50214549-63d1-f92e-d4e7-dc6533477d83@ti.com>
Date: Fri, 8 Dec 2017 09:56:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171208155514.7696-1-dmurphy@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Resent to include DT maintainers

On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> 
> v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
> 
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..fc7f5f9f234c 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
>  =======
>  
>  	as3645a@30 {

Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Dan

> -		#address-cells: 1
> -		#size-cells: 0
> -		reg = <0x30>;
>  		compatible = "ams,as3645a";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x30>;
>  		flash@0 {
>  			reg = <0x0>;
>  			flash-timeout-us = <150000>;
> 


-- 
------------------
Dan Murphy