From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbbJFHth (ORCPT ); Tue, 6 Oct 2015 03:49:37 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:59843 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbbJFHtf (ORCPT ); Tue, 6 Oct 2015 03:49:35 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Manjeet Pawar , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Akhilesh Kumar , Rohit Thapliyal , pankaj.m@samsung.com Subject: Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Date: Tue, 06 Oct 2015 09:49:29 +0200 Message-ID: <5022096.8QRzW0l3EJ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444109743-8561-1-git-send-email-manjeet.p@samsung.com> References: <1444109743-8561-1-git-send-email-manjeet.p@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jmo2L/GMI7rjPk82pXJyCHN8SeAthYSa4Tm6YHBJb1mZwHzrYxV 4vsQMBI4LBNwrvkB1AeIB8sp4PMcLF4Y0HUPfScCFW6glyKKpy9t0d4HebQ0BKN5c33j1PK aP0jNsl94UuK1UCuS6G1UMGw+PLrHec+pEF7+nnVQ9Hyp33Ht8K9cW83OIgyr5lwjA0yjVp J15DdZFY3qsVUpdqJYLAA== X-UI-Out-Filterresults: notjunk:1;V01:K0:x6Zv+eYTIxQ=:c6lh+giSQKvyYGNDImLx1V 88nAlICqiuvodXVU45MOcd40g5JuKM4x6vTXiXMO1NFA4xHyjb/cqREwVB9L9EnNK3mIUkWpI +px//Kyn+4TPoFeT+27bHsD/qL+oXmEdbvJ+GyA7rOluHsHuEGvyyd9LFY9Uk0+bAKQaMKimq 0C2iuheNk9mHrnfBYAMAMFMdvO4WqVDZ6zmWeQqHHklM8sIkkzjvqe2Rmy/15nLFS9nXhgIef ZGJROOAu7QnCEM2pcEKyVVjB1J6ug9aoGAIeud6EZkWE4uU4xjoIyZF2XmEuCek4Hmzi8m4OF adCr5RBRC7uRTX14wmt0D1ZJQlmsFPOKRsyrL32AcEaWhil2JFBi+u5/leWXrIs0IrRtwUJFy K7nBJY/MpNzelfQ6WziBnqN9i8eEDEzDmHfbC3/hHzgWIEXzaoaaLUq70qlpytkq6oBvfaqLn ML1TSzH/yLmHwV++d/WSADy0AlcKdrddslxNdowQ1y7ZLxJrnMl8gnEmx9iDFsTAw2egwYIX8 v5o0uz8T3p4xNzUzTvUsCnuvJFnYBZs2A85FCdaDmTSI+tgeL+kV1k15MByWOKMUiP2DZ280l nUc+VR/b2JloXlPTtY8kI+SRBiFNweK1IkDNbzW/YRhFkeD6CNnJV5axij6f3k4QbcTz1K81+ de38rM1MvJ/oQnZTrI0j82aQIo8JGz0vwlMUGtgQd0HEkU+vDz4+WAyzpoC8dc47M/lCKTcRP pAmU9PpbeExiRQ7j Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06 October 2015 11:05:43 Manjeet Pawar wrote: > MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel. > This patch fixes this issue. > > This issue is reported in LTP (testcase: sigaltstack02.c). > Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1" > Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel > it is set to 2048 so testcase gets failed. > > Testcase Output: > sigaltstack02 1 TPASS : stgaltstack() fails, Invalid Flag value,errno:22 > sigaltstack02 2 TFAIL : sigaltstack() returned 0, expected -1,errno:12 > > Reported Issue in Glibc Bugzilla: > https://sourceware.org/bugzilla/show_bug.cgi?id=16850 > > Bugfix in Glibc-2.22: > https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/ > sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705 > f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e > > Signed-off-by: Akhilesh Kumar > Signed-off-by: Manjeet Pawar > Signed-off-by: Rohit Thapliyal This looks correct now. A few more points though: * My first thought would have been to do this by first defining the two symbols before the #include, and then adding an #ifdef in the generic file. Both approaches work though, any other opinions on this? * It seems that PowerPC has the same bug. Care to fix that as well? * Do we need to backport this to stable? * Can you explain in the changelog how the numbers were decided? I don't see any other architecture using 5kb and cannot see why it has to be this value rather than something else. Arnd > --- > v1 -> Changes in uapi overall header > v2 -> Changes done in arm64 headers > > arch/arm64/include/uapi/asm/signal.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/include/uapi/asm/signal.h b/arch/arm64/include/uapi/asm/signal.h > index 8d1e723..5ac56cf 100644 > --- a/arch/arm64/include/uapi/asm/signal.h > +++ b/arch/arm64/include/uapi/asm/signal.h > @@ -21,4 +21,9 @@ > > #include > > +#undef MINSIGSTKSZ > +#undef SIGSTKSZ > +#define MINSIGSTKSZ 5120 > +#define SIGSTKSZ 16384 > + > #endif >