From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757876Ab2HHORD (ORCPT ); Wed, 8 Aug 2012 10:17:03 -0400 Received: from na3sys009aog119.obsmtp.com ([74.125.149.246]:34904 "EHLO na3sys009aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756548Ab2HHORA (ORCPT ); Wed, 8 Aug 2012 10:17:00 -0400 Message-ID: <502274DA.9020204@ti.com> Date: Wed, 08 Aug 2012 17:16:58 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120723 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: Samuel Ortiz , Liam Girdwood , Tony Lindgren , Dmitry Torokhov , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Benoit Cousson Subject: Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support References: <1344418887-5262-1-git-send-email-peter.ujfalusi@ti.com> <1344418887-5262-5-git-send-email-peter.ujfalusi@ti.com> <20120808131356.GS16861@opensource.wolfsonmicro.com> <50226CF4.1010202@ti.com> <20120808135253.GC16861@opensource.wolfsonmicro.com> In-Reply-To: <20120808135253.GC16861@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2012 04:52 PM, Mark Brown wrote: >> The hs_extmute is used for reducing pop noise on the headset. The sequence is >> described in the TRM and it need to be done within the codec driver since it >> is within the sequence. > > Is the point it's at in the sequence the end? On both ends :o On HS enable: the extmute has to be enabled, run the power on sequence for the HS, wait for ramp, disable the HS extmute. On stop: enable the extmute, run the sequence, wait for ramp, release the extmute. > We can always add a patch stubbing it out as part of the series, or in a > branch in the OF tree that we can pull in. If you are OK with the hassle I can add a patch to the series for include/linux/of.h to handle this. -- Péter