From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbcFXJBn (ORCPT ); Fri, 24 Jun 2016 05:01:43 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:53587 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbcFXJAH (ORCPT ); Fri, 24 Jun 2016 05:00:07 -0400 From: Arnd Bergmann To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: hiddev: use IS_ENABLED() for USB_HIDDEV Date: Fri, 24 Jun 2016 11:02:07 +0200 Message-ID: <5023053.7F6zTHqVIR@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:gynJecGucr8v8o6cYTKCj4bEoR4z7veF6SJRxorMIQ8FnNEkkFm 2qFWGUQLg6TJSSlmEAzTRRH5qxqZsTKkcOPB7QK66OjwnqkogOXSrrcEYBdRxbV/nlW6XWT desv7bjzwJ7L+4EuyGoXkBBsWwYKonanDmsZpqSfuYOTwzXRPM3V5xNG37zjM98kbHdyHRM 5BWZIsj5dFOGEyf+G6XzA== X-UI-Out-Filterresults: notjunk:1;V01:K0:WnfehB/Ru2I=:vgh2X+CFkF8KB1zfoSMCze 6WLnU6yazekzldd6K/9eogZ6Lvjo7lasgEhseblKaszV4cGY+bOGy3BSeKNb6RaLwGCe0PybT 3RzfAOiBYLWe95jktLoSzyb7dLhz0S0dpXttWgCntIKHZPH2dI0F9JV+hb4LnCSQk8I8sJt/N 4e66Go0K/A5+NqzG7dX98J9oerSL4U4CSkKfBH/bFXQNs4HRlEwy3yqFHJqjXlNXRSFZZ1yaj IG330jROVnp9fu+As03MDwcGIX24RXZUOpW5BuF+fckAJKJn8e5+/WTAJpvd3j/VaeOo03wBQ XlVvtcs+HsWY8LQ7la7azRcLBk+0DH/sJ5duJxrVQzkR/I6zgwTXU8CzfCVn7HzGe9ROzj04v bpxCD5riWZrIz4tJVI4O9kJ0+WAD+bOIQjuNbo4sWw7OjLRSFlqkncfo+PcGlf9Y7f9lcSYk4 Bdz6Dm0nWaA6k4WpejDnJysHF6sc7H6vg1FCCAe3FuX300zBHDd/rmgITa0PrDMfE7IQOtAsb H2GZP18OFv2nBxnY46rtFFDwTDpuec8CWtqYsB30awA9EPIaM1oBZpnAPpQXpl51CTpQZ/iGz DXG+OrpfV3blzArBkNO3r3hWngvH1Juj6EtZAYf87CJI9QqiZGdNFhg7ssTrlnr4mnjRAl8tn Wfzn9R+n9ShMcrt6WGGyb246XJPjCNF97zA94dWomI23/rXtwh2RBJfOsgUn96IkqQ5LwXj7G em51QeHCwTYxzTPR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 24, 2016 10:28:50 AM CEST Jiri Kosina wrote: > From: Jiri Kosina > > Use IS_ENABLED() for checking USB_HIDDEV to make sure compilation works > for all possible config combinations. > > Signed-off-by: Jiri Kosina > --- > include/linux/hiddev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hiddev.h b/include/linux/hiddev.h > index a5dd814..b6f48d6 100644 > --- a/include/linux/hiddev.h > +++ b/include/linux/hiddev.h > @@ -37,7 +37,7 @@ struct hid_usage; > struct hid_field; > struct hid_report; > > -#ifdef CONFIG_USB_HIDDEV > +#if IS_ENABLED(CONFIG_USB_HIDDEV) > int hiddev_connect(struct hid_device *hid, unsigned int force); > void hiddev_disconnect(struct hid_device *); > void hiddev_hid_event(struct hid_device *hid, struct hid_field *field, > > CONFIG_USB_HIDDEV is a 'bool' option, so the two look completely equivalent. If we wanted to make USB_HIDDEV a loadable module by itself, we'd also need to export those functions and change both the Kconfig and Makefile files to ensure that you can't have USB_HIDDEV=m in combination with USB_HID=y. What problem are you trying to fix specifically? Arnd