From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.107.208.11 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794922402; b=ZoEZxKovNzroUzITG+jE7xbtvVR0r5h5F3JYcc93MdjuzG7U15OS5rzpVq89uLTjCG5u 7+mWtn2ERUv6uOnKZXg+Pk1yBfhoBYd8Vvy0D5owOaFKJctB9k+Qq1ikU0zL7OuvOyg0R BcDl6rnqy7LU+EA4QuncK5j2csQIiPtFM8ZDPXli7k/qNHepVNOGxX1jiqwqh0+nakdxb KhGH+p4QE5kCgwjh8k1LBN4Esz89h/gR7sKn1aVX0oSDGiy37wVgTKRSMhUXzkF6lcxT0 pqjB7yo/X7a3V1HPfNXCedHRy/tGohBDjCY4iwp7VT+76v0VwpfT25xR1zenw67Iung== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794922402; h=DMARC-Filter:DKIM-Signature:Received:Received:Message-ID:Date: User-Agent:Subject:To:Cc:References:Content-Language: X-Nvconfidentiality:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-ClientProxiedBy:MIME-Version: X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=n9ORRfdt+r3cpTwxLc4/zFTvsS8DbVbgmg6DbzlRcWE=; b=pi2HmfNVVWfW/ShqXwNBOUb1QO5IqXltD2xUKvWBIXXT5l9uhy3DmF2MHZRiT08jG+uJ IYVoO/5xftPZGXsdCUskxGraOo+mHLpc3DLZOCiMjLCbH7yGZeh5LOeiuZQF6MhWwQiaR PsRgVS/MD01TiDfq8FzHG68JLtMRKaT4QBItzM2IE39NGj3kR7P+t+ctTOcUBj4rKtymT g+kBHVm7toQMDNAv9/zKsGMOydeEquZJb2AsezF9JR2BW969985JUV2pkreWd3KGEvKiL yAsWk0qCusyaEcx0zumL08l5ZqgIhH1XU4V5v8LR5mYB9k9qW1BtFfPJRVTOUv5ypow== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=A6qVf5no; arc=pass header.oldest-pass=0 smtp.remote-ip=40.107.208.11 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011011.outbound.protection.outlook.com [40.107.208.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85413606A323; Tue, 17 Nov 2026 13:33:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85413606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=A6qVf5no ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fwLf9GrTSJqfdFj0WypJKoyn67DZcLqHmXaIJWk6eNqhp7cEMi8VBL6YooUDPM+V94mnT62H7oTqP4Rd7OmPo1gW3GkDvuVgwmownaDwCyBJdFM5lEo8Huvk3SCSfC9hETBnYA7zvgZUeVdycfEufBSHcYw0BbfrhJM5pcazH/kLxrvGKKNlBhrqzNgWT7s896OSTmJ+y0NARI2+3UU8VqPP37IPgTEnOhWMaJvTFFUuzRZ99NoziQ+gFm0CNKgY+wCJ1VOfT948p9LYy1zZEjwydHpp2rQm12Ok8JvjY0NVT8ZwDKPRb0boNJ659WrvEC6pcCDDinZGuq6Hm8uYYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9ORRfdt+r3cpTwxLc4/zFTvsS8DbVbgmg6DbzlRcWE=; b=QULwonK702fSARWxnHv7FsUC1z5gHb72tcNJDQOx/Pt7bALGd2J/lZDGkpf5+7mpOskyAP09+BULvRKHM5kSjBWhvcBfpmQ6pBUGN+35O+UjOq2bD1hIm+tWodu0ZsMmNja0Q7cIU2K0dGNIIQb6tQ6SZjEW7ZHa610zHp//i3FtzW+ajGoPI0oK6eSwi9Mw7LhyecCX9HozvmkVJoiJDa1m4bKJGEQuZatHJiCHhIBpUtC2V14Kn0jYFfXajWGoj96cOgZ6ZqEwUPsHleGC7TX/0Fah2C1f3L93TLgjHY0QlRYHF5QVhiju9/FE3hG917c3GZvGxxCH3Efzru6y3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n9ORRfdt+r3cpTwxLc4/zFTvsS8DbVbgmg6DbzlRcWE=; b=A6qVf5noIKkhCOA/wAe44gTTJgWDdBDuuXjgWw3seVsRdX3ielMD6dzRmXS9MzmBQq5jMJh8RHcQuHFNYCvqXnbYfLgKv/63eBQtAbHudmd1sRiyZBb8+kpH8FyXu5w74HpbGCgGJ0X+72z8dH1ofcPTn0JMt13Nn8c8+eXPDU+MrsLFh/lJVX9UAgnH+kvRGdWl+VTqEJ/0JDDohwcFpSDSZFjRnNxpBInjprIHCVUPLkEHh5nIC4gLVwLnWMF37V9HqPnVqtMZnVJH0E/k6yzOMP7k6yu7TT4iQ0gN2yCbQsxNoC5mYD+BvMt+Pm6fvIp994Q8rle17iIuvCAQwA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LY0PR12MB257519.namprd12.prod.outlook.com (2603:10b6:404:22b::7) by CY8PR12MB7436.namprd12.prod.outlook.com (2603:10b6:930:50::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 13:33:11 +0000 Received: from LY0PR12MB257519.namprd12.prod.outlook.com ([fe80::89e:d21:20ab:ae5a]) by LY0PR12MB257519.namprd12.prod.outlook.com ([fe80::89e:d21:20ab:ae5a%5]) with mapi id 15.21.0615.013; Tue, 17 Nov 2026 13:33:11 +0000 Message-ID: <5023b5cd-e454-4789-8290-92be81e14ec5@nvidia.com> Date: Tue, 17 Nov 2026 19:03:01 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] PCI: tegra194: Use FIELD_*() for register fields To: Bjorn Helgaas Cc: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, robh@kernel.org, thierry.reding@kernel.org, jonathanh@nvidia.com, vidyas@nvidia.com, cassel@kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org References: <20261116170109.GA71319@bhelgaas> Content-Language: en-US X-Nvconfidentiality: public From: Manikanta Maddireddy In-Reply-To: <20261116170109.GA71319@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0046.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:98::22) To LY0PR12MB257519.namprd12.prod.outlook.com (2603:10b6:404:22b::7) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LY0PR12MB257519:EE_|CY8PR12MB7436:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fb2c232-e751-4b54-43ff-08df44af52c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|7416014|376014|366016|22082099003|18002099003|13003099007|56012099006|11063799006|261022075727099003|261026121527099003|261021123027099003|261021135927099003|10067099003; X-Microsoft-Antispam-Message-Info: gBA5g4Rdna1rZRSgbzqDiBKGojZodoGz2YIP/kKShK1tLReDmlye+Wz/7rouI3rUgFaFARrPeE9A7fYVkda5z6sDgZhwZHUdol8mrNGdiEgXVxj6er11OUF01ISSpPdAPYt1idof/LM/HOKUrUCemdvrgGyvuLaHTaI/4/GLCuu5PGr+sXksMLFr/KMxRDaedV/XB07AquUxRfPFzAoVu88Kg7iMXoplZ/zqsc68iy7v1GPa85XzrC25nH0IJD6tHPJOmfINu2z7LydWV9w5a8POODS9/VYVKi3wG/T5LOajSmiP7wNKuT9ee81HnWFbZc1s3qAK8FEFhfqEnTQTNtX/REeAL6ZikGyD8CffDtjg6GV14diuN0r2ujPe6f+WOyHEjYp4OavcHzKG8I2yYe2d4PJPVUEWto01l5m6BttHEWl+8r1LssqB9JtiOXyGwtzDIOjtJljyuXSyAikwh4mGOVmaBk8Js5emRBDFq0zz2zFnTKOSRkqHlcXFlMdc676SHMGihfNn/9OQ52Rw3nIk6nhhKzqrzKrv7XhxrpIKyPYHh3S2z+uEaApGaw1R7Je1raa1WqmuwQBGmjA1O+dyl67FpODVomUnWh+diO7PlqhITjdzrlx0CAshhJZ1LORlIUB1qmSP0wGw3PzWoEH59vCR0OcQ8pJy0kgEFcY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LY0PR12MB257519.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(7416014)(376014)(366016)(22082099003)(18002099003)(13003099007)(56012099006)(11063799006)(261022075727099003)(261026121527099003)(261021123027099003)(261021135927099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXd0ZVhxRzNpRXVlblVzM3FIeTB2azdEbGRoclpkam1iVDJuQ1BZL0RkVnlk?= =?utf-8?B?Q2xDc1NiSmpHVjBId0o3WUlBTGdneDhHc1RacWRKYjY0cXZWdWg1UkM0RzVI?= =?utf-8?B?SXR4c1d1b21EcXNRcmRaM0UzVWRMb3poN3h0QUNEL2s5UXRZNlpFY3Q3cTh3?= =?utf-8?B?L0Y1RWVQeW1zeEJzV2g5RXUybXdTS05QeWxkNVErbzVMOUcrbWVHY2c3MUNE?= =?utf-8?B?d3RWNU9Yb0JjajAwQlp3QzhVNGNxSTl5T1dLeldXeXo0RHZCWTNUVUg3U29p?= =?utf-8?B?QUtIK1lETkhsOUl4YTZCRDN3dm5tWlNTblNBcE8rblBtYVZVWk0yODZiSTg0?= =?utf-8?B?QkRuU0FPYnJWcXg1Tm5hN2ZRQXhhNTd5QjVibDlIc05LOCtqNDY4TTdxQ1Zj?= =?utf-8?B?NFVkYkVBR0M1TUQvb2doWEk1Nmd6NU5OSUl0ZC9wczZpK2NqWFBJeEhUeTc1?= =?utf-8?B?ZFZ6bEMrTzNTSENtRnlqNWFYQ3dmbFhjd1FSZHVnb2hHQjZJbWdVSHA4NThm?= =?utf-8?B?SStzU1oxR1ZVaDJoQzZtK1lBcTA5QXAzdm56T2orWFhka2dyREJBVDR1aTFW?= =?utf-8?B?ZUZGMDBLMnFOd2JpL2RJZHp4NlE4S0lyTVh3NjdFREcvOGFJNUpMWTVFNjBD?= =?utf-8?B?VExrTno0UXQrS3RHSzJDRXJUa1hRMm1rK1RENys2d0JKSlhVa3VmYjdPbjlY?= =?utf-8?B?YTczTFhQU0ZaY3JYVWJLNHNFV3pzb29GTzBUdzBGQSsxQ0pVR3hXNDR3MEQ4?= =?utf-8?B?VWMwWWV4NWowamVQbjRVQlN0TDVRNlhWZEl2SDJIMnpZUk9pbTVSWmIyTHBw?= =?utf-8?B?R1h2TVBibHVGTmNZSzZNbDdTRThra1dwaWhxVFM3OFpCMS9iY21aL3RzWGFL?= =?utf-8?B?SXU3UW01UjZEd0F0VkkvRnFUYkprb3VUTzlkV1NYc3RtSDFiaTkvL3pqRTRm?= =?utf-8?B?UFNaUVB2L2VxRS9DYWxUQnl5c1JuUy9TSi8wL3VxWGdJZlZHYS9rY0U3NnFv?= =?utf-8?B?dk5hWTdjRW0zbDJIdkMyMU1KcHdjN1AvTVEwWkRqU2lHN2NhTS9tN0RsWW1K?= =?utf-8?B?ZFI3Z0VWUWVpSXk2bG5lWlNBYmtoa2FCRGJpR0kzaVU4UWhNcnJSeE0yQlQ2?= =?utf-8?B?QlRveEJtTHFsRHpkUmJLRW1FZ3FhTVhQbi9oYTI4RHhGRHp6dXlWOFUxaHRr?= =?utf-8?B?NzNIanVQOWQxdXFxTTV2VVpOWHNkQlE3alJXYlBzdEEweGpFOVY1RWMrRzdK?= =?utf-8?B?U2RqWjdBM0ZpaHJSVGdsSCtnWGl0YVRxVGIxc0RIK1Y2MmR5S3B5cXFmZmRL?= =?utf-8?B?OCtab1laUnVNd1pEem9HcGMzeHJHaFFOc2k2aXptbEJTSVNobGxlZiszcVNq?= =?utf-8?B?aldZcEFYWFlocTdCMnVVaUYvNGkwRnlVSW5paUFhOVB5T3k3K2p6Qml4amtl?= =?utf-8?B?L2lSNWRMUmJLNmxjMjBHNkc1MGdWVFBMazhQdCtoYlVEeWl5cGQyNXZ2VnZ4?= =?utf-8?B?VjEvcTR4VHJ2Uy9FbjJLZXQ4emVzdVhOcnZiNURJVTB3VFZucENFaWZ5WmdI?= =?utf-8?B?SUdKeDZaNU9waWFEYlhlZFlzYTlMNjBSL2NMSWFsT1dzRElCc3ZVSU9lR04r?= =?utf-8?B?NXJZRC9zVU4vQi9QN01PK2ljaXVVTGsrUDdRM3FKTFQwWk1jNTN1RmhtWDVy?= =?utf-8?B?NTBnNE9JNHNTemxNQUlWUW5aUDg0VFlTM0NHU0dUVTZpaHNPSlJ2VFd4RWZ6?= =?utf-8?B?b3FqYWV4U0xxOXFCZUNPT1lDNGdRSGNEcTdXdlM2RFFEOS9lZnpmeXp0Sm9s?= =?utf-8?B?dVNEQzFnRmZpUUVxdXpPOTVCYm1UeTVYK2p5eldObTZCaklPUGs2ZUhVUTBs?= =?utf-8?B?cldONTlqOW94cU1GRlk3R3QxTFFqT1dLN2NVSjJWWFgvdlZHaHZFWllveVo1?= =?utf-8?B?aWdJeUYyM3dMQUhlOFZMZ3VIamVRUFQreklGZTF0K0NramxUUHNXZFp3bk12?= =?utf-8?B?dVdZL21GZVFPVHJORS9aVGIzZS9WOVF1SGo5KzkrWEh3M2tKbitkSldKQVBX?= =?utf-8?B?ejVFWE9ZeFdVbThHQWoyV2FET1BIMWNHSlk2WFl6OW9yR3FaZlYyVmhqZ1Fp?= =?utf-8?B?OHgydVBNM3Viajd2SUlPcC9WdFBhWkpMaTNFazlVYzRIdnVUZEg5cTBCbUpI?= =?utf-8?B?clJCL1hoN1FPaXZLQ2FPb2x6T1JBVkVRUGpSR21Cblp5RENLeStUZjlhUmJO?= =?utf-8?B?dExteklDdUtVSE9mK2R5Z0dqbnh1YmcwSlB6SlJ1OVQzWTEzR0JsNVIrMTVw?= =?utf-8?B?QUhqdWZCS3grY3p0Q24vdjF0QVVJRUhnVjNpVnFxNnJIRU5mZVdEdz09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fb2c232-e751-4b54-43ff-08df44af52c8 X-MS-Exchange-CrossTenant-AuthSource: LY0PR12MB257519.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 13:33:11.1554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tzN6vK53SJFR1V2SYIEoJcY2J/A06zpM/gJwEyXRPLx81cJL2YxW2OjCAPftpbJX2tPXPElmCR7NzL7Kvh8BYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7436 On 16/11/26 10:31 pm, Bjorn Helgaas wrote: > On Mon, Nov 09, 2026 at 11:19:06AM -0600, Bjorn Helgaas wrote: >> On Mon, Nov 02, 2026 at 02:52:37PM +0530, Manikanta Maddireddy wrote: >>> Several Tegra194 APPL and DesignWare register fields are programmed >>> with open-coded shifts, which makes the register programming more >>> verbose than necessary. >>> >>> Use FIELD_PREP(), FIELD_MODIFY() and FIELD_GET() at the Tegra call >>> sites where values are shifted into fields. The LTSSM state constants >>> are converted from pre-shifted register values to unshifted field >>> values for FIELD_GET(). >>> >>> Suggested-by: Bjorn Helgaas >>> Link: https://lore.kernel.org/r/20260515070753.3852840-2-mmaddireddy@nvidia.com >> >> Thanks for this patch; it's great to get rid of the redundant *_SHIFT >> definitions. >> >> But I'm confused about why this Link: is here. It points to "[PATCH >> v3 1/2] PCI: tegra194: Use aspm-l1-entry-delay-ns DT property for L1 >> entrance latency", which looks like a functional change. >> >> This patch should be zero functional changes; it should be purely >> mechanical changes from explicit shifts to using FIELD_MODIFY() etc. >> >> This patch doesn't mention aspm-l1-entry-delay-ns, so it doesn't >> *look* like this includes the [PATCH v3 1/2] content. > > https://lore.kernel.org/r/20260515070753.3852840-2-mmaddireddy@nvidia.com > is a change that was already merged as 87f493041e20 ("PCI: tegra194: > Use aspm-l1-entry-delay-ns DT property for L1 entrance latency"). > > *This* patch only reworks it to use FIELD_MODIFY(). I dropped that > Link: tag to avoid confusion. And also put both PORT_AFAC_L0S_ELM and > PORT_AFAC_L1_ELM on one line since they fit easily. Thank you, Bjorn, for removing the misleading Link tag and simplifying the formatting. I intended to reference your suggestion to replace the SHIFT definitions with FIELD() helpers, but linked to the original patch instead of your review comment at https://lore.kernel.org/all/20260520193024.GA84903@bhelgaas/ -- nvpublic