From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752581AbdJLPaz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 11:30:55 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:17875 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751690AbdJLPax (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 11:30:53 -0400
X-AuditID: b6c32a37-c75ff70000001076-e6-59df8aaba292
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: sis: make const array specialtv static,
 reduces object code size
Date: Thu, 12 Oct 2017 17:30:49 +0200
Message-id: <502610747.RoFXOuGC48@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20170913154137.6886-1-colin.king@canonical.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7bCmge7qrvuRBuu6jC1+r+5ls7jy9T2b
        xYm+D6wWl3fNYbNYvfIxuwOrx6yGXjaP+93HmTw+b5LzWDDjP0sASxSXTUpqTmZZapG+XQJX
        xtMp71gLOtgqug99Z2xg3M/SxcjBISFgIrH5R3kXIxeHkMAORok3x+axQTjfGSW29d1g72Lk
        BCuacfYxM0RiA6PE8/uTmSCcr4wSrzd1sIJUsQlYSUxsX8UIMlZEQFPi/LkikBpmgYmMEjta
        XjKB1AgLpErc6f/DCGKzCKhK3Fy+iw3E5hXQlvi15zYziC0q4CWxZV87E8gcTgFbiUP9YRAl
        ghI/Jt9jAbGZBeQl9u2fygph60icPbaOEWSXhMAaNonuKb+ZIK52kTi67B4rhC0s8er4FnaI
        l6UlLh21hQhPZ5TY/lsConczo8Sq3ROgPraWOHz8ItQCPol3X3tYIXp5JTrahCBKPCR+P14J
        Nd5R4sXCGeyQMJkANGfea6YJjLKzkNw9C8nds5DcvYCReRWjWGpBcW56arFhgbFecWJucWle
        ul5yfu4mRnAS0DLfwbjhnM8hRgEORiUeXoGq+5FCrIllxZW5hxglOJiVRHg9OoFCvCmJlVWp
        RfnxRaU5qcWHGKU5WJTEecXWX4sQEkhPLEnNTk0tSC2CyTJxcEo1ME49UFi5+o26R86BN/Me
        /ejnmdH5p+RW+nSNP55r9v5j2+5ffy3n28QdlkulXdLz8vXUJHPO/i1S3XA6XD7afe6Epsgz
        bH+P3zppEn3HJHnBxjROsYXvb3YqfPWSWyZlM+XNvO9OkSaPTfhkNqRZnu6352DK+KNgqPZl
        1p2q786d5jOL7sv9uaTEUpyRaKjFXFScCACs0X6A/gIAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t9jQd3VXfcjDVb/VrT4vbqXzeLK1/ds
        Fif6PrBaXN41h81i9crH7A6sHrMaetk87ncfZ/L4vEnOY8GM/ywBLFFcNimpOZllqUX6dglc
        GU+nvGMt6GCr6D70nbGBcT9LFyMnh4SAicSMs4+Zuxi5OIQE1jFKvLm8Esr5yigxb1MzM0gV
        m4CVxMT2VYxdjBwcIgKaEufPFYHUMAv0M0qsfraeHaRGWCBV4k7/H0YQm0VAVeLm8l1sIDav
        gLbErz23weaICnhJbNnXzgQyh1PAVuJQfxjErkmMEg+2fWCFqBeU+DH5Hth1zALyEvv2T2WF
        sLUk1u88zjSBkX8WkrJZSMpmISlbwMi8ilEytaA4Nz232KjAMC+1XK84Mbe4NC9dLzk/dxMj
        MHC3Hdbq28F4f0n8IUYBDkYlHl6BqvuRQqyJZcWVuYcYJTiYlUR4PTqBQrwpiZVVqUX58UWl
        OanFhxilOViUxHlv5x2LFBJITyxJzU5NLUgtgskycXBKNTBuKFO7xbKgQfNETzLr46s9wspT
        UgSqJl2SdvaruLGqof7pgeQTR6Kdw+r36At/9+Xeayp+dO/lhcznFYMXv9L0ZVh+tPd7WLHw
        lxcuF4J8n351uX6lmudU6iGH5JnVjKLr0iM3Hd12X+ZDk3j1u99MM5QkTnx96fJS9lIP30qZ
        H/0PX15vq3iuxFKckWioxVxUnAgApcFx8FgCAAA=
X-CMS-MailID: 20171012153051epcas1p1a804b176eab701f500e09b66ecba1ad2
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.142
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 101P
X-CMS-RootMailID: 20170913154142epcas2p41e38ee4285ed856ee6b98edf267da1de
X-RootMTR: 20170913154142epcas2p41e38ee4285ed856ee6b98edf267da1de
References: <CGME20170913154142epcas2p41e38ee4285ed856ee6b98edf267da1de@epcas2p4.samsung.com>
        <20170913154137.6886-1-colin.king@canonical.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, September 13, 2017 04:41:37 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the const array specialtv on the stack, instead make it
> static.  Makes the object code smaller by over 1100 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>  179899	   7504	      0	 187403	  2dc0b	drivers/video/fbdev/sis/init301.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>  178720	   7568	      0	 186288	  2d7b0	drivers/video/fbdev/sis/init301.o
> 
> (gcc version 7.2.0, x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics