From: Michael Tokarev <mjt@tls.msk.ru>
To: Jens Axboe <axboe@kernel.dk>
Cc: majianpeng <majianpeng@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Don't use static to define "void *p" in show_partition_start().
Date: Sun, 12 Aug 2012 19:45:36 +0400 [thread overview]
Message-ID: <5027CFA0.1020207@msgid.tls.msk.ru> (raw)
In-Reply-To: <501B8EBE.5040006@kernel.dk>
On 03.08.2012 12:41, Jens Axboe wrote:
> On 08/03/2012 07:07 AM, majianpeng wrote:
[]
>> diff --git a/block/genhd.c b/block/genhd.c
>> index cac7366..d839723 100644
>> --- a/block/genhd.c
>> +++ b/block/genhd.c
>> @@ -835,7 +835,7 @@ static void disk_seqf_stop(struct seq_file *seqf, void *v)
>>
>> static void *show_partition_start(struct seq_file *seqf, loff_t *pos)
>> {
>> - static void *p;
>> + void *p;
>>
>> p = disk_seqf_start(seqf, pos);
>> if (!IS_ERR_OR_NULL(p) && !*pos)
>
> Huh, that looks like a clear bug. I've applied it, thanks.
It also looks like a -stable material, don't you think?
Thanks,
/mjt
next prev parent reply other threads:[~2012-08-12 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 5:07 majianpeng
2012-08-03 8:41 ` Jens Axboe
2012-08-12 15:45 ` Michael Tokarev [this message]
2012-08-13 0:38 ` Jianpeng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5027CFA0.1020207@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome