mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, LinX Z" <linx.z.chen@intel.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
	yanmin_zhang@linux.intel.com
Subject: [PATCH V2] x86/smp: Fix cpuN startup panic
Date: Mon, 13 Aug 2012 13:04:37 +0900	[thread overview]
Message-ID: <50287CD5.1090104@intel.com> (raw)

From: Lin Chen <linx.z.chen@intel.com>

We hit a panic while doing cpu hotplug test.
<0>[  627.982857] Kernel panic - not syncing: smp_callin: CPU1 started up but did not get a callout!
<0>[  627.982864]
<4>[  627.982876] Pid: 0, comm: kworker/0:1 Tainted: G ...
<4>[  627.982883] Call Trace:
<4>[  627.982903]  [<c18f2977>] panic+0x66/0x16c
<4>[  627.982918]  [<c12234cc>] ? default_get_apic_id+0x1c/0x40
<4>[  627.982931]  [<c18ef96d>] start_secondary+0xda/0x252

During BSP bootup AP, it is possible that BSP be preempted before
finishing STARTUP sequence of AP(set cpu_callout_mask) which maybe cause
AP busy wait for it. At present, AP will wait for 2 seconds then panic.

This patch let AP waits for 60 seconds at maximum.

Signed-off-by: Yanmin Zhang <yanmin_zhang@linux.intel.com>
Signed-off-by: Chen LinX <linx.z.chen@intel.com>
---
  arch/x86/kernel/smpboot.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 7c5a8c3..447aa3b 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -162,9 +162,9 @@ static void __cpuinit smp_callin(void)
  	 */

  	/*
-	 * Waiting 2s total for startup (udelay is not yet working)
+	 * Waiting 60s total for startup (udelay is not yet working)
  	 */
-	timeout = jiffies + 2*HZ;
+	timeout = jiffies + 60*HZ;
  	while (time_before(jiffies, timeout)) {
  		/*
  		 * Has the boot CPU finished it's STARTUP sequence?
-- 
1.7.1

                 reply	other threads:[~2012-08-13  4:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50287CD5.1090104@intel.com \
    --to=linx.z.chen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome