From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58423316182 for ; Mon, 17 Nov 2025 08:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763368015; cv=none; b=Z8yCPgHd/riTZwDdKsxBOXH7gXSBfchjnYmDVKhU5D7Omg/FVbj14jQ4CfJ6a/8J18NZ3Ve6YAj6H3HXiNIr1AyS1TvD2GebioNlzZEFHzAz+JBMYywhUIBrPjWozJDYw9GoE7AS7YiVQ/0Br2mKR58viRGzIdXdAyb9nQX7cSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763368015; c=relaxed/simple; bh=e0u67h8c6X5Oufcm+F6KES5Q9Ho5t4kXs9hus9cYsMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SPjeguTVVtnCvIKHRXcmZj3lfmlpikFFKCMe0WVVNqXa1G7GyOK7FjKn0yCFJWJv75wwNORG0UmuaDDusQ+FRau8ETuDCxVphfYErlLA8uEOAuttpdt0OjGmoQQroK/qGOC7FizEksivBTAXD4anHBuTUwH3ENFdV/2zJ/HL6dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jHv2Tr/P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VN7JzEue; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jHv2Tr/P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VN7JzEue" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AH4p6IB3192130 for ; Mon, 17 Nov 2025 08:26:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HqY/mTbwRbbtUtoeLVGkT10SH32hcso7gcIJc0Xa8IM=; b=jHv2Tr/PnrHJGNXk OmzN+QIqTJCCbFnlawgb16rv8+vy90SH5IEOHH4CriTCl6ZNbeauw4bUbi5Af61I /FgTNm10vAkGk//Om/gHlkGeDoY2WwkPb59J4K26kN4Yz9uvgI6OeO8ELATiHOKS 9HINnpiDits2RX6Dox5xw2gLFBv4SRLV6hwS+VojtK30uf1xXDb41NQREwWFdEci huwiVyT5IsveNHdn1OktZ3iHfNTv90tVTPiHtLLiXitNx+CRqXm+ueQyAfSb+xF1 FsVP8F+cos2FfLWdU0DZicno2WJwwP8irN2gir4lqpcYnJUgETcbpjVF7cWv0o0n qRuv4w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aejkmbx1p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 08:26:53 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b8ed43cd00so4389598b3a.2 for ; Mon, 17 Nov 2025 00:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763368012; x=1763972812; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HqY/mTbwRbbtUtoeLVGkT10SH32hcso7gcIJc0Xa8IM=; b=VN7JzEueUii8hCPM8OyGlHmlbUUu1Qz6yaf464IiDNZWMC6B1R0coSSBvUO/kMrBlK s4d0K8RpB5XhfTgqaCY2cdgRsDwXMcFYWtg27YEC92NZOTJuIU+JC4BX/KA3UBYWlEAN OPy7fBe6CNI5yzpepkpMJQ5aq8j4xIvtFqBvLYNbBBmGpf7Wy2tyOp5U0ZIhMIIQ9Yfh vriadRrJ4/LXpmbOFmDRGJiwP1eXFUg0nb/zNxVhj1hZlJvbzIhjjKGujtkCgqp1m9ku jK3XRGh/ARNghysE3flyNHIpVwMI54ehFV2KxdEtoieOJ+dZoAneXhT3plk9oow1jEFD l97g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763368012; x=1763972812; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HqY/mTbwRbbtUtoeLVGkT10SH32hcso7gcIJc0Xa8IM=; b=LOA4KdUHPqshOEYPDMC78mc73Jgdbd0WS8Hp/gzn9LFFwze30Ffnl34VLjCyeXuJKx JzAF0/YcTQwwm/lSZpbnL1H/1XpapJnHZz01deoY08560kEnNrnftYcf1co892EyRc9t 2H6fWodKIjoHer0eR3YTfwc1VuEp8vGfJaVE5PkqCa2C2IWMpBr1G1RYB8uRsjac/xpR w98uDm3YTQ4X+YnONLmf5+FW0g2HTomRQP2VC7nDHaO5xP+aVbpxF8F6hzrIbzCYEDKZ yL6XFh6WBYtACebe9Lu0rq8aebvNyIcnsQdVIPPPEYrPLOSbOs4pq4kiH5V1rVmrb1Bg e0nA== X-Forwarded-Encrypted: i=1; AJvYcCUSWTcxo4DrFj1WgToLkJKmzLg+MWugmUo+FY4ud/Ps8dYEOykJUof5mJKPVK3HpFDWNZN7Xs5XUCiEgX4=@vger.kernel.org X-Gm-Message-State: AOJu0YzFbUVUMOhCQAQKM9QpKIVCU9zh6gJgtV2SkyQ8c7SP8MMN3Vu1 LUVOxLIgoerjJtb6SZcz3RHXLNBdznKmaVtBAYbXVtegLQFxlHsfUZ0RS0X5y3k9xiy+jjNgYI0 bMOadEJL4I3yjrULInI/+gsgHlv8ftHpw/hyknld17Lzy4mDVtVHQo9onqd92FwJI7QU= X-Gm-Gg: ASbGncu5TQ6QSePN0mqSAeIR2SF2vBbPQqTq9FtYuP0OZvjhOG9LRWeIJuJh/ti/D8E sCG/MZObWygQfMJVK8ZJxARizKkI4BjDKWfFNQ5HrGGC7LoNd+6lEehY+JqET9b+JDEFnsV53Ot 8chWXDnFnQjq+t45kljwDIY34IYVcY0jFCPd+r8DiYlrPWB1yOGK8+qSUyGysUY0q7iKKJFnf1g yVh4p/HfdheesahN+3FbIliSHf2LTkodVr/Cy7/nAMUtDcHbGL8f/D3DgKjc52gKKkgWq2Z3l+o GlspbPv05jKPeSHsI7tya+KIxu7I3prrfvsuznox2e4IiXz2KgLbPPZ7R5HhwHJGe0/zbXqDG9/ e/Jbhi4nBxomNvDioQ7gIRZlBvEQ= X-Received: by 2002:a05:6a00:3cc8:b0:7ae:d1d:d500 with SMTP id d2e1a72fcca58-7ba39b79f58mr12947157b3a.4.1763368012129; Mon, 17 Nov 2025 00:26:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEpTUvvlvQ/gY1LvJSEYh8KPw1Xo9CAyCAYMvNk0llGfT+RuLXrP+uy5JL8RGjP++Xd4cfEw== X-Received: by 2002:a05:6a00:3cc8:b0:7ae:d1d:d500 with SMTP id d2e1a72fcca58-7ba39b79f58mr12947127b3a.4.1763368011662; Mon, 17 Nov 2025 00:26:51 -0800 (PST) Received: from [10.217.199.21] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b924be37fbsm12515549b3a.1.2025.11.17.00.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 00:26:51 -0800 (PST) Message-ID: <5029600e-a3b8-4aec-a374-526fb3f6417e@oss.qualcomm.com> Date: Mon, 17 Nov 2025 13:56:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] soc: qcom: rpmh: Add support to read back resource settings To: Konrad Dybcio , Kamal Wadhwa , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251022-add-rpmh-read-support-v2-0-5c7a8e4df601@oss.qualcomm.com> <20251022-add-rpmh-read-support-v2-2-5c7a8e4df601@oss.qualcomm.com> <9e8b47d8-9a20-40da-a6eb-cdd167c108dd@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <9e8b47d8-9a20-40da-a6eb-cdd167c108dd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PqRPOY8nTY_1yJj7mzGiOvLkmN5AWErL X-Authority-Analysis: v=2.4 cv=N6ok1m9B c=1 sm=1 tr=0 ts=691adc4d cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=6vPrc6N6B8lL3SuiZ9oA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDA3MCBTYWx0ZWRfXzNgL/0OhBAln xeSH1XzoNOOw7Hh5AG3VUweoqLmyKws/sDlqQWspiUHD0HLh5OHEn0zxdTSpe/6zBSOorRcUItd oZih+B9+VE1eKTx6d83mfQwDpyBeMcms611NpiJdnYL61ocmRkKysvYZoPYkt3kfRqW7gzkQrca N/j8Z+XzSEc4WiBNNt1FeBgDl2Kdled4/MO+kQ6jrUZ2bDZ8+244kjOFfMpKsdLDAhHwqx6eV5R 9TW3JxpuogK2L/VQU9sXKVhUn+Fxg65/7gVnWYe/ZyvuK2duwILve0REG5qr8CP6TUJWisMK5c4 lnYKxwlfbNQ3IGddKhHGcsbKps8iJy7bIS+bfVbAQmt8xQrJCfMXuXobiIFfeFma3NLMYxONYJG qz3sSBOl8hRbufSCBarkVLCcjWpvkA== X-Proofpoint-GUID: PqRPOY8nTY_1yJj7mzGiOvLkmN5AWErL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_02,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1011 priorityscore=1501 adultscore=0 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170070 On 11/12/2025 4:56 PM, Konrad Dybcio wrote: > On 10/21/25 11:08 PM, Kamal Wadhwa wrote: >> From: Maulik Shah >> >> All rpmh_*() APIs so far have supported placing votes for various >> resource settings but the H/W also have option to read resource >> settings. >> >> This change adds a new rpmh_read() API to allow clients >> to read back resource setting from H/W. This will be useful for >> clients like regulators, which currently don't have a way to know >> the settings applied during bootloader stage. >> >> Link: https://lore.kernel.org/r/20250623-add-rpmh-read-support-v1-1-ae583d260195@oss.qualcomm.com >> Signed-off-by: Maulik Shah >> Signed-off-by: Kamal Wadhwa >> --- > > [...] > >> +int rpmh_read(const struct device *dev, struct tcs_cmd *cmd) >> +{ >> + DECLARE_COMPLETION_ONSTACK(compl); >> + DEFINE_RPMH_MSG_ONSTACK(dev, RPMH_ACTIVE_ONLY_STATE, &compl, rpm_msg); >> + int ret; >> + >> + ret = __fill_rpmh_msg(&rpm_msg, RPMH_ACTIVE_ONLY_STATE, cmd, 1, true); >> + if (ret) >> + return ret; >> + >> + ret = __rpmh_write(dev, RPMH_ACTIVE_ONLY_STATE, &rpm_msg); > > Is there a reason for making this ACTIVE_ONLY? Yes, using ACTIVE_ONLY makes the read request place immediately to read back the current resource setting. Sleep/Wake are H/W based trigger and are not applicable for this API. Thanks, Maulik