From: Stephen Warren <swarren@wwwdotorg.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, Gyungoh Yoo <jack.yoo@maxim-ic.com>,
Stephen Warren <swarren@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH] regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()
Date: Mon, 20 Aug 2012 09:01:39 -0600 [thread overview]
Message-ID: <50325153.3000305@wwwdotorg.org> (raw)
In-Reply-To: <1345271585.7986.0.camel@phoenix>
On 08/18/2012 12:33 AM, Axel Lin wrote:
> Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
> fixes below build warning:
>
> CC [M] drivers/regulator/max8907-regulator.o
> drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_remove':
> drivers/regulator/max8907-regulator.c:353:23: warning: 'pmic' is used uninitialized in this function [-Wuninitialized]
That's odd; while this warning and the patch are obviously correct, I
can't get my compiler to warn about it at all, and it usually is pretty
strict about emitting warnings. Oh well.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-08-20 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 6:33 Axel Lin
2012-08-20 15:01 ` Stephen Warren [this message]
2012-08-21 3:36 ` Axel Lin
2012-08-20 19:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50325153.3000305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jack.yoo@maxim-ic.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome