From: Greg Ungerer <gregungerer@westnet.com.au>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: drop unused parts of 68VZ328 Makefile
Date: Tue, 21 Aug 2012 23:21:37 +1000 [thread overview]
Message-ID: <50338B61.8050101@westnet.com.au> (raw)
In-Reply-To: <1345399091.1771.12.camel@x61.thuisdomein>
Hi Paul,
On 08/20/2012 03:58 AM, Paul Bolle wrote:
> DRAGEN2 should obviously be CONFIG_DRAGEN2, but the screen.h entry it
> triggers only references files that are nowhere to be found in the
> current tree. Besides, nothing uses screen.h. So just drop all that.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Thanks, I'll take this through the m68knommu git tree.
Applied to for-next branch.
Regards
Greg
> ---
> 0) Entirely untested. It's hard to see what could break, though.
>
> 1) These lines got added to the tree with a patch called "m68k-nommu:
> change build process to use common head code". That patch predates the
> mainline git repository by a month. That patch did not add screen.xbm or
> xbm2lcd.pl.
>
> 2) For what it's worth: screen.xbm and xbm2lcd.pl can be found at
> http://cvs.uclinux.org/cgi-bin/cvsweb.cgi/uClinux-2.4.x/arch/m68knommu/platform/68VZ328/de2/ .
>
> arch/m68k/platform/68VZ328/Makefile | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/arch/m68k/platform/68VZ328/Makefile b/arch/m68k/platform/68VZ328/Makefile
> index a49d75e..8166741 100644
> --- a/arch/m68k/platform/68VZ328/Makefile
> +++ b/arch/m68k/platform/68VZ328/Makefile
> @@ -1,11 +1,5 @@
> #
> -# Makefile for arch/m68knommu/platform/68VZ328.
> +# Makefile for arch/m68k/platform/68VZ328.
> #
>
> obj-y := config.o
> -extra-$(DRAGEN2):= screen.h
> -
> -$(obj)/screen.h: $(src)/screen.xbm $(src)/xbm2lcd.pl
> - perl $(src)/xbm2lcd.pl < $(src)/screen.xbm > $(obj)/screen.h
> -
> -clean-files := $(obj)/screen.h
>
prev parent reply other threads:[~2012-08-21 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 17:58 Paul Bolle
2012-08-21 13:21 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50338B61.8050101@westnet.com.au \
--to=gregungerer@westnet.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®