From: Alex Shi <alex.shi@intel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: apparent regressions from TLB range flushing page set
Date: Wed, 22 Aug 2012 16:54:29 +0800 [thread overview]
Message-ID: <50349E45.3020502@intel.com> (raw)
In-Reply-To: <50349AB4020000780008A4B5@nat28.tlf.novell.com>
On 08/22/2012 03:39 PM, Jan Beulich wrote:
>>>> Alex Shi <alex.shi@intel.com> 08/22/12 5:24 AM >>>
>> On 08/20/2012 10:12 PM, Jan Beulich wrote:
>> I was thought you have 'Agreed' for xen part code. :)
>
> I had agreed to it being done the right way, and I had pointed out the
> problem once. I can't say for sure that I looked at the most recent rev
> closely enough to spot the issue still being unfixed.
>
>>> For one, while TLB_FLUSH_ALL gets passed as 'end' argument to
>>> flush_tlb_others(), the Xen code was made to check its 'start'
>>> parameter.
>>
>> Do you mean need the following change? --untested.
>
> Yes. I'd question though whether for that special case it shouldn't be
> start _and_ end to get passed the special value.
Actually the special value is already there in old code.
so, what's your meaning of the question?
>
> Jan
>
next prev parent reply other threads:[~2012-08-22 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:12 Jan Beulich
2012-08-22 3:23 ` Alex Shi
2012-08-22 7:39 ` Jan Beulich
2012-08-22 8:54 ` Alex Shi [this message]
2012-08-22 13:22 ` Jan Beulich
2012-08-24 8:15 ` Alex Shi
2012-08-22 3:26 ` Alex Shi
2012-08-22 7:44 ` Jan Beulich
2012-08-22 7:53 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50349E45.3020502@intel.com \
--to=alex.shi@intel.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome