From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbeACLSx (ORCPT + 1 other); Wed, 3 Jan 2018 06:18:53 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:44626 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbeACLSu (ORCPT ); Wed, 3 Jan 2018 06:18:50 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180103111847epoutp02e37b03b0fec250aaf98841096ae62771~GSMMUQPgW0061600616epoutp026 X-AuditID: b6c32a46-9adff700000010ee-22-5a4cbc16b245 From: Bartlomiej Zolnierkiewicz To: Sinan Kaya Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Antonino Daplas , "open list:NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER" , "open list:FRAMEBUFFER LAYER" , open list Subject: Re: [PATCH V4 24/26] video: fbdev: riva: deprecate pci_get_bus_and_slot() Date: Wed, 03 Jan 2018 12:18:44 +0100 Message-id: <5036032.4uFqTqHFln@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <04f4cf20-9b57-3eff-79b6-abfda1258174@codeaurora.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42LZdljTQld8j0+Uwa9GRouf3V/YLK58fc9m senxNVaLifvPsluc6PvAanF51xw2i7PzjrNZNE7axmTR/FjdgdPjcl8vk8fOWXfZPe53H2fy 2Lyk3uPzJrkA1igum5TUnMyy1CJ9uwSujPcH+pkKznJUPD6ymrWB8S9bFyMnh4SAicTVhy+Y uxi5OIQEdjBK/H98BMr5ziix7u10VpiqfT+mM0EkNjBKrF56gx0kISTwlVHizix1EJtNwEpi YvsqRhBbREBV4u+NZWCTmAXeMkn8OH6eCSQhLBAisebdFKCpHBwsQEXrv8qBmLwCmhLHP6iA VIgKeEls2dcOVs0p4CRx6/Z/sJG8AoISPybfYwGxmQXkJfbtn8oKYetInD22jhFklYTAZTaJ LbePQL3mInGw8zszhC0s8er4FnYIW1ri2aqNjBD2dEaJ7b8lIJo3M0qs2j0Bqsha4vDxi1Ab +CQ6Dv9lBzlUQoBXoqNNCKLEQ+JJz0ZoADlK9P5YwgoJoAuMEuuPbWOawCg7C8nhs5AcPgvJ 4QsYmVcxiqUWFOempxYbFRjpFSfmFpfmpesl5+duYgQnDS23HYxLzvkcYhTgYFTi4eXo844S Yk0sK67MPcQowcGsJMLrluUTJcSbklhZlVqUH19UmpNafIhRmoNFSZy3NcAlSkggPbEkNTs1 tSC1CCbLxMEp1cAoucL3nPRt85qcUw7GaWe2ubFaKq6sCzf04/xRIuduxx9xZ/rp98vNN6+x eF40ca0P+4SV0W9zLy7u9yt70nai43/KSvnPZxsM1vYKOkdr+h/q41a6vj4xwMcvYldxwtuv /dLNCZ8ZJlQoNv73+pDsbpG7bUa9yqJnRy4Zd0oHL9u7PGG31gIlluKMREMt5qLiRADmaMh0 FgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t9jQV2xPT5RBi1XhC1+dn9hs7jy9T2b xabH11gtJu4/y25xou8Dq8XlXXPYLM7OO85m0ThpG5NF82N1B06Py329TB47Z91l97jffZzJ Y/OSeo/Pm+QCWKO4bFJSczLLUov07RK4Mt4f6GcqOMtR8fjIatYGxr9sXYycHBICJhL7fkxn ArGFBNYxSmzcotDFyAVkf2WU2DzlMytIgk3ASmJi+ypGEFtEQFXi741lzCBFzALvmSTuvdjC DpIQFgiRWPNuClADBwcLUNH6r3IgJq+ApsTxDyogFaICXhJb9rWD7eIUcJK4dfs/I8SuC4wS /zYcYwZJ8AoISvyYfI8FxGYWkJfYt38qK4StJbF+53GmCYz8s5CUzUJSNgtJ2QJG5lWMkqkF xbnpucVGBUZ5qeV6xYm5xaV56XrJ+bmbGIFBvu2wVv8OxsdL4g8xCnAwKvHwJkzwjhJiTSwr rsw9xCjBwawkwuuW5RMlxJuSWFmVWpQfX1Sak1p8iFGag0VJnJc//1ikkEB6YklqdmpqQWoR TJaJg1OqgXFm5yz3Ta88Ys7mcYW+U9ixfPVNadFvaXOY+zi9X5TbScrMm7XqZ+y1v9zqsaFf vk9YqF5+vLfE2U6CO+/ajoh+sxZv9Qf3tec93+3ve0EztNpuw9NTjb1GPC/9qk2E6y+csu9c 9ndKEY9S2qHL7PVCh5Llnno9nRN5bY/Xy0dWirNXrP+/Jl+JpTgj0VCLuag4EQDIc4SVbgIA AA== X-CMS-MailID: 20180103111846epcas2p3aaf963b154a324d2cb49a2c3c2cad420 X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20180102133737epcas1p2cb1a62d59d9a83564db1f265c1643bf4 X-RootMTR: 20180102133737epcas1p2cb1a62d59d9a83564db1f265c1643bf4 References: <1513661883-28662-1-git-send-email-okaya@codeaurora.org> <04f4cf20-9b57-3eff-79b6-abfda1258174@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tuesday, January 02, 2018 08:37:32 AM Sinan Kaya wrote: > On 12/19/2017 12:38 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > > where a PCI device is present. This restricts the device drivers to be > > reused for other domain numbers. > > > > Getting ready to remove pci_get_bus_and_slot() function in favor of > > pci_get_domain_bus_and_slot(). > > > > struct riva_par has a pointer to struct pci_dev. Use the pci_dev member > > to extract the domain information. > > > > Change the function signature for CalcStateExt and RivaGetConfig to pass > > in struct pci_dev in addition to RIVA_HW_INST so that code inside the > > riva_hw.c can also calculate domain number and pass it to > > pci_get_domain_bus_and_slot(). > > > > Signed-off-by: Sinan Kaya > > Any feedback here, most of the remaining patches have the ACK except these? Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics