From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F53925393C for ; Fri, 25 Jul 2025 20:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753473945; cv=none; b=IGHJ3AK/xDpjAa+0DfDPqd10QXSaw0v4JE0GxxXVFKuuhK2udpJvwaaW0KV0l98PEYglxKzgGs7fuJps81gyFKV1pe/Np+FHouLJmNxejPyZhNsY8ikQXwH5xdesNIqQ4ksHutg4G7UyUeqOoPBshI7jMVN86NEhhZ+mb6MryGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753473945; c=relaxed/simple; bh=BUPe7Bwp8bQZeYAHAMmSuaWDl+6ZZSMknoUu34bHwxE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=QB4tn6M/VO6UPFXpTQoktMnzQIr+JMeSHj4AzgfHke7VQA7F1zYkYXqc1qzUpNoZ0V9ApAm84dYWZGl3+6af1Qa0jeV2bUnP5dPg/uBmrTkRYmtUpwIc8W+HAINXjOfReruDZDerx/Sob3cKndv2jwYBWDZMlzfOn2rFMCdvSMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.2.102] (213.87.128.105) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 25 Jul 2025 22:50:17 +0300 Message-ID: <5037fd77-ab7c-406c-b53f-d882a3585a44@omp.ru> Date: Fri, 25 Jul 2025 22:50:14 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware_loader: prevent integer overflow in firmware_loading_timeout() To: Luis Chamberlain CC: Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , References: <62c63afc-5d56-46fc-aac4-87081498602d@omp.ru> Content-Language: en-US From: Sergey Shtylyov Organization: Open Mobile Platform In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.1, Database issued on: 07/25/2025 19:36:05 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 195126 [Jul 25 2025] X-KSE-AntiSpam-Info: Version: 6.1.1.11 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 63 0.3.63 9cc2b4b18bf16653fda093d2c494e542ac094a39 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_arrow_text} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 213.87.128.105 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 213.87.128.105 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: {Tracking_ip_hunter} X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: ApMailHostAddress: 213.87.128.105 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 07/25/2025 19:38:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 7/25/2025 4:35:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 7/5/25 4:39 AM, Luis Chamberlain wrote: [...] >> In firmware_loading_timeout(), *int* result of __firmware_loading_timeout() >> multiplied by HZ might overflow before being implicitly cast to *long* when >> being returned. Rewrite the function using check_mul_overflow() and capping >> the result at LONG_MAX on actual overflow... >> >> Found by Linux Verification Center (linuxtesting.org) with the Svace static >> analysis tool. >> >> Signed-off-by: Sergey Shtylyov >> Cc: stable@vger.kernel.org > > Reviewed-by: Luis Chamberlain And? :-) I assume this patch has to go thru the driver-core.git repo managed by Greg KH, and Greg seems to ignore at least my USB patches... :-/ so I guess this patch has no chance of hitting Linus' tree as well? > Luis MBR, Sergey