From: Chanwoo Choi <cw00.choi@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Free MICDET IRQ on error during probe
Date: Mon, 27 Aug 2012 08:54:20 +0900 [thread overview]
Message-ID: <503AB72C.9020505@samsung.com> (raw)
In-Reply-To: <1346014700-5912-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 08/27/2012 05:58 AM, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index fa2114f..13eafcb 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -488,11 +488,13 @@ static int __devinit arizona_extcon_probe(struct platform_device *pdev)
> ret = input_register_device(info->input);
> if (ret) {
> dev_err(&pdev->dev, "Can't register input device: %d\n", ret);
> - goto err_fall_wake;
> + goto err_micdet;
> }
>
> return 0;
>
> +err_micdet:
> + arizona_free_irq(arizona, ARIZONA_IRQ_MICDET, info);
> err_fall_wake:
> arizona_set_irq_wake(arizona, ARIZONA_IRQ_JD_FALL, 0);
> err_fall:
Thanks much,
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
I will apply this patch to
http://10.90.51.51/cgi-bin/gitweb.cgi?p=linux-samsung;a=shortlog;h=refs/heads/extcon-for-next
and you can check it after some hours.
prev parent reply other threads:[~2012-08-26 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 20:58 Mark Brown
2012-08-26 23:54 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503AB72C.9020505@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome