From: Jonathan Cameron <jic23@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: use IIO_CHAN_INFO_RAW rather than 0
Date: Mon, 27 Aug 2012 18:25:16 +0100 [thread overview]
Message-ID: <503BAD7C.5010608@kernel.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EEFD76@DQHE02.ent.ti.com>
On 08/16/2012 08:39 AM, Kim, Milo wrote:
> (a) For better readability, replace 0 with IIO_CHAN_INFO_RAW.
> (b) Make same line-format as other apis()
> : iio_read_channel_scale() and iio_read_channel_offset()
>
merged. Thanks.
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/iio/inkern.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index bd09245..5103337 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -239,8 +239,10 @@ int iio_read_channel_raw(struct iio_channel *chan, int *val)
> goto err_unlock;
> }
>
> - ret = chan->indio_dev->info->read_raw(chan->indio_dev, chan->channel,
> - val, &val2, 0);
> + ret = chan->indio_dev->info->read_raw(chan->indio_dev,
> + chan->channel,
> + val, &val2,
> + IIO_CHAN_INFO_RAW);
> err_unlock:
> mutex_unlock(&chan->indio_dev->info_exist_lock);
>
>
prev parent reply other threads:[~2012-08-27 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 7:39 Kim, Milo
2012-08-27 17:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BAD7C.5010608@kernel.org \
--to=jic23@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome